Revert "Enable continuous mode/runtime counter relocation for coverage builds"
This reverts commit 0265879ffa10a660230994a3ca36a96c1fec0d18.
Reason for revert: Speculative, might have caused https://crbug.com/1510916
Original change's description:
> Enable continuous mode/runtime counter relocation for coverage builds
>
> Enabling the continuous mode for coverage builds allows us to recover
> coverage data for test processes run in sandboxes while avoiding the CQ
> failures that we see with the noncontinuous mode that flushes all the
> counters to disk at process shutdown. This should also be expected to
> recover coverage data for tests that exit abnormally.
>
> Enabling the continuous mode is also the first step in landing several
> changes that will potentially improve instrumented test performance.
>
>
> Cq-Include-Trybots: luci.chromium.try:chromeos-amd64-generic-siso-rel
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-siso
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_siso_rel_ng
> Cq-Include-Trybots: luci.chromium.try:mac-siso-rel
> Change-Id: Iab1177b2e8f5a24887a33417d1556c90f1002363
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4953786
> Reviewed-by: Junji Watanabe <[email protected]>
> Reviewed-by: danakj <[email protected]>
> Reviewed-by: Ben Pastene <[email protected]>
> Reviewed-by: Hans Wennborg <[email protected]>
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Dominic Farolino <[email protected]>
> Reviewed-by: Prakhar Asthana <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1235959}
Change-Id: I8d1b44632ee8b8cc3468e1ad6e5d9a1239ea352c
Cq-Include-Trybots: luci.chromium.try:chromeos-amd64-generic-siso-rel
Cq-Include-Trybots: luci.chromium.try:ios-simulator-siso
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_siso_rel_ng
Cq-Include-Trybots: luci.chromium.try:mac-siso-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5115704
Auto-Submit: Nico Weber <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Owners-Override: Nico Weber <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1236394}
diff --git a/tools/code_coverage/coverage.py b/tools/code_coverage/coverage.py
index 9fe6abd..e622653d 100755
--- a/tools/code_coverage/coverage.py
+++ b/tools/code_coverage/coverage.py
@@ -504,12 +504,9 @@
#
# For other cases, "%4m" is chosen as it creates some level of parallelism,
# but it's not too big to consume too much computing resource or disk space.
- #
- # "%c" expands out to nothing, but it enables the continuous coverage mode
- # where profile counter updates are continuously written to the profraw file.
profile_pattern_string = '%1m' if _IsFuzzerTarget(target) else '%4m'
expected_profraw_file_name = os.extsep.join(
- [target, '%c', profile_pattern_string, PROFRAW_FILE_EXTENSION])
+ [target, profile_pattern_string, PROFRAW_FILE_EXTENSION])
expected_profraw_file_path = os.path.join(
coverage_utils.GetCoverageReportRootDirPath(OUTPUT_DIR),
expected_profraw_file_name)
@@ -870,7 +867,7 @@
assert len(targets) == 1, "Only one wpt target can be run"
target = targets[0]
expected_profraw_file_name = os.extsep.join(
- [target, '%c', '%2m', PROFRAW_FILE_EXTENSION])
+ [target, '%2m', PROFRAW_FILE_EXTENSION])
expected_profraw_file_path = os.path.join(
coverage_utils.GetCoverageReportRootDirPath(OUTPUT_DIR),
expected_profraw_file_name)
