Fix cross-version upgrade test breakage from commit fe07100e82.
authorNathan Bossart <[email protected]>
Wed, 2 Jul 2025 18:26:33 +0000 (13:26 -0500)
committerNathan Bossart <[email protected]>
Wed, 2 Jul 2025 18:26:33 +0000 (13:26 -0500)
commit0c2b7174c362d3092eb7eabf0117a8d47c64ce0e
tree3098b913d654d832bc42ea113d70eb06dda03b64
parentbb109382ef403a4827caacf2978e82f46593600c
Fix cross-version upgrade test breakage from commit fe07100e82.

In commit fe07100e82, I renamed a couple of functions in
test_dsm_registry to make it clear what they are testing.  However,
the buildfarm's cross-version upgrade tests run pg_upgrade with the
test modules installed, so this caused errors like:

    ERROR:  could not find function "get_val_in_shmem" in file ".../test_dsm_registry.so"

To fix, revert those renames.  I could probably get away with only
un-renaming the C symbols, but I figured I'd avoid introducing
function name mismatches.  Also, AFAICT the buildfarm's
cross-version upgrade tests do not run the test module tests
post-upgrade, else we'll need to properly version the extension.

Per buildfarm member crake.

Discussion: https://postgr.es/m/aGVuYUNW23tStUYs%40nathan
src/test/modules/test_dsm_registry/expected/test_dsm_registry.out
src/test/modules/test_dsm_registry/sql/test_dsm_registry.sql
src/test/modules/test_dsm_registry/test_dsm_registry--1.0.sql
src/test/modules/test_dsm_registry/test_dsm_registry.c