Improve error messages around REPLICATION and BYPASSRLS properties.

Clarify wording as per suggestion from Wolfgang Walther.
No back-patch; this doesn't seem worth thrashing translatable
strings in the back branches.

Tom Lane and Stephen Frost

Discussion: https://postgr.es/m/a5548a9f-89ee-3167-129d-162b5985fcf8@technowledgy.de

diff --git a/src/backend/commands/user.c b/src/backend/commands/user.c
index 293e7e4c0c1ceeb166f94257de61f10c10c7cc89..0e6800bf3e4f3f584bbb0b2f6f8ae999f5d94bf1 100644 (file)
--- a/src/backend/commands/user.c
+++ b/src/backend/commands/user.c
@@ -305,7 +305,7 @@ CreateRole(ParseState *pstate, CreateRoleStmt *stmt)
        if (!superuser())
            ereport(ERROR,
                    (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-                    errmsg("must be superuser to change bypassrls attribute")));
+                    errmsg("must be superuser to create bypassrls users")));
    }
    else
    {
@@ -719,14 +719,14 @@ AlterRole(AlterRoleStmt *stmt)
        if (!superuser())
            ereport(ERROR,
                    (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-                    errmsg("must be superuser to alter superusers")));
+                    errmsg("must be superuser to alter superuser roles or change superuser attribute")));
    }
    else if (authform->rolreplication || isreplication >= 0)
    {
        if (!superuser())
            ereport(ERROR,
                    (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
-                    errmsg("must be superuser to alter replication users")));
+                    errmsg("must be superuser to alter replication roles or change replication attribute")));
    }
    else if (bypassrls >= 0)
    {