Avoid assuming that we know the spelling of getopt_long's error messages.

I've had enough of "fixing" this test case.  Whatever value it has
is limited to verifying that pgbench fails for an unrecognized switch,
and we don't need to assume anything about what getopt_long prints in
order to do that.

Discussion: https://postgr.es/m/9427.1547701450@sss.pgh.pa.us

diff --git a/src/bin/pgbench/t/002_pgbench_no_server.pl b/src/bin/pgbench/t/002_pgbench_no_server.pl
index b78057d05097401a892d6908721119726f66d626..69a6d03bb3f8ffe5e12990eb4b218742ce44751a 100644 (file)
--- a/src/bin/pgbench/t/002_pgbench_no_server.pl
+++ b/src/bin/pgbench/t/002_pgbench_no_server.pl
@@ -66,7 +66,7 @@ my @options = (
    [
        'bad option',
        '-h home -p 5432 -U calvin -d --bad-option',
-       [ qr{(unrecognized|illegal) option}, qr{--help.*more information} ]
+       [qr{--help.*more information}]
    ],
    [
        'no file',