Avoid trying to write an empty WAL record in log_newpage_range().

If the last few pages in the specified range are empty (all zero),
then log_newpage_range() could try to emit an empty WAL record
containing no FPIs.  This at least upsets an Assert in
ReserveXLogInsertLocation, and might perhaps have bad real-world
consequences in non-assert builds.

This has been broken since log_newpage_range() was introduced,
but the case was hard if not impossible to hit before commit 3d6a98457
decided it was okay to leave VM and FSM pages intentionally zero.
Nonetheless, it seems prudent to back-patch.  log_newpage_range()
was added in v12 but later back-patched, so this affects all
supported branches.

Matthias van de Meent, per report from Justin Pryzby

Discussion: https://postgr.es/m/[email protected]

diff --git a/src/backend/access/transam/xloginsert.c b/src/backend/access/transam/xloginsert.c
index e3d5937479fec7c730b000222f68ccec4ba840a6..ea7e2f67af604e625f98b6ed1594951dafef69a7 100644 (file)
--- a/src/backend/access/transam/xloginsert.c
+++ b/src/backend/access/transam/xloginsert.c
@@ -1304,6 +1304,10 @@ log_newpage_range(Relation rel, ForkNumber forknum,
            blkno++;
        }
 
+       /* Nothing more to do if all remaining blocks were empty. */
+       if (nbufs == 0)
+           break;
+
        /* Write WAL record for this batch. */
        XLogBeginInsert();