Adjust pg_dump tag for relation stats.
authorJeff Davis <[email protected]>
Fri, 28 Feb 2025 04:40:21 +0000 (20:40 -0800)
committerJeff Davis <[email protected]>
Fri, 28 Feb 2025 04:42:12 +0000 (20:42 -0800)
Do not use fmtId(), just use dobj->name directly, like for table data.

src/bin/pg_dump/pg_dump.c

index 7c38c89bf08cfbbfa2c6d5b3d4a4716e6e9d72a0..4f4ad2ee15070a963ae8c05882f38b59e0dde3a9 100644 (file)
@@ -10490,7 +10490,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
    PGresult   *res;
    PQExpBuffer query;
    PQExpBuffer out;
-   PQExpBuffer tag;
    DumpId     *deps = NULL;
    int         ndeps = 0;
    char       *qualified_name;
@@ -10522,9 +10521,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
        ndeps = dobj->nDeps;
    }
 
-   tag = createPQExpBuffer();
-   appendPQExpBufferStr(tag, fmtId(dobj->name));
-
    query = createPQExpBuffer();
    if (!fout->is_prepared[PREPQUERY_GETATTRIBUTESTATS])
    {
@@ -10695,7 +10691,7 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
    PQclear(res);
 
    ArchiveEntry(fout, nilCatalogId, createDumpId(),
-                ARCHIVE_OPTS(.tag = tag->data,
+                ARCHIVE_OPTS(.tag = dobj->name,
                              .namespace = dobj->namespace->dobj.name,
                              .description = "STATISTICS DATA",
                              .section = rsinfo->postponed_def ?
@@ -10707,7 +10703,6 @@ dumpRelationStats(Archive *fout, const RelStatsInfo *rsinfo)
    free(qualified_name);
    destroyPQExpBuffer(out);
    destroyPQExpBuffer(query);
-   destroyPQExpBuffer(tag);
 }
 
 /*