Remove the flaky check in event_trigger_login regression test

The query checks that pg_database.dathasloginevt is unset on connect when
there are no event triggers.  However, unsetting this flag is implemented in
a non-blocking way, so a concurrent autovacuum connection breaks this check.
It doesn't seem we can do much with this, at least within a regression test.
So, remove it.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/44807d19-81a6-3884-3e0f-22dd99aac3ed%40gmail.com

diff --git a/src/test/regress/expected/event_trigger_login.out b/src/test/regress/expected/event_trigger_login.out
index 174879578be9e400ddf9d7eb9d9e8c36c57512a4..4f43c2352f6a879c1c692d1586b6f72deca393c9 100644 (file)
--- a/src/test/regress/expected/event_trigger_login.out
+++ b/src/test/regress/expected/event_trigger_login.out
@@ -37,9 +37,3 @@ DROP TABLE user_logins;
 DROP EVENT TRIGGER on_login_trigger;
 DROP FUNCTION on_login_proc();
 \c
-SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';
- dathasloginevt 
-----------------
- f
-(1 row)
-

diff --git a/src/test/regress/sql/event_trigger_login.sql b/src/test/regress/sql/event_trigger_login.sql
index b8e39f75261f4725e80b01424136ff19233645ed..060c105e60963432d7ed1c2744ac10fc0a116f3f 100644 (file)
--- a/src/test/regress/sql/event_trigger_login.sql
+++ b/src/test/regress/sql/event_trigger_login.sql
@@ -22,4 +22,3 @@ DROP TABLE user_logins;
 DROP EVENT TRIGGER on_login_trigger;
 DROP FUNCTION on_login_proc();
 \c
-SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';