Improve some error messages.
authorAmit Kapila <[email protected]>
Wed, 21 Sep 2022 04:13:59 +0000 (09:43 +0530)
committerAmit Kapila <[email protected]>
Wed, 21 Sep 2022 04:13:59 +0000 (09:43 +0530)
It is not our usual style to use "we" in the error messages.

Author: Kyotaro Horiguchi
Reviewed-By: Amit Kapila
Discussion: https://postgr.es/m/20220914.111507.13049297635620898[email protected]

src/backend/replication/pgoutput/pgoutput.c
src/backend/storage/file/fd.c

index 03b13ae6798d50bb9a357a866cf0b6f317f4723d..880580ed00a10a0fcc19e0fbdab645c0d50aefea 100644 (file)
@@ -441,13 +441,13 @@ pgoutput_startup(LogicalDecodingContext *ctx, OutputPluginOptions *opt,
        if (data->protocol_version > LOGICALREP_PROTO_MAX_VERSION_NUM)
            ereport(ERROR,
                    (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                    errmsg("client sent proto_version=%d but we only support protocol %d or lower",
+                    errmsg("client sent proto_version=%d but server only supports protocol %d or lower",
                            data->protocol_version, LOGICALREP_PROTO_MAX_VERSION_NUM)));
 
        if (data->protocol_version < LOGICALREP_PROTO_MIN_VERSION_NUM)
            ereport(ERROR,
                    (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-                    errmsg("client sent proto_version=%d but we only support protocol %d or higher",
+                    errmsg("client sent proto_version=%d but server only supports protocol %d or higher",
                            data->protocol_version, LOGICALREP_PROTO_MIN_VERSION_NUM)));
 
        if (data->publication_names == NIL)
index 20c3741aa1ee2861552282d2d491fe24e1d4dd1a..073dab2be59a162a701dd96c21a0a048bcce8cfc 100644 (file)
@@ -978,7 +978,7 @@ set_max_safe_fds(void)
        ereport(FATAL,
                (errcode(ERRCODE_INSUFFICIENT_RESOURCES),
                 errmsg("insufficient file descriptors available to start server process"),
-                errdetail("System allows %d, we need at least %d.",
+                errdetail("System allows %d, server needs at least %d.",
                           max_safe_fds + NUM_RESERVED_FDS,
                           FD_MINFREE + NUM_RESERVED_FDS)));