Mark Scan as an abstract node type, too.

On further review, this one is never instantiated either.

diff --git a/src/include/nodes/plannodes.h b/src/include/nodes/plannodes.h
index 6ed765cbe4f8b9674daace8e0f3db65a825f7dc5..dca2a21e7abbd7b2410e683265b4588f45d9eb55 100644 (file)
--- a/src/include/nodes/plannodes.h
+++ b/src/include/nodes/plannodes.h
@@ -371,10 +371,14 @@ typedef struct BitmapOr
 /*
  * ==========
  * Scan nodes
+ *
+ * Scan is an abstract type that all relation scan plan types inherit from.
  * ==========
  */
 typedef struct Scan
 {
+   pg_node_attr(abstract)
+
    Plan        plan;
    Index       scanrelid;      /* relid is index into the range table */
 } Scan;

diff --git a/src/test/modules/test_oat_hooks/test_oat_hooks.c b/src/test/modules/test_oat_hooks/test_oat_hooks.c
index c9869b21fded3c68f0f15668028e93255e3be253..0ad77e743de00f914a5739f4280a1298f8152840 100644 (file)
--- a/src/test/modules/test_oat_hooks/test_oat_hooks.c
+++ b/src/test/modules/test_oat_hooks/test_oat_hooks.c
@@ -492,9 +492,6 @@ nodetag_to_string(NodeTag tag)
        case T_BitmapOr:
            return "BitmapOr";
            break;
-       case T_Scan:
-           return "Scan";
-           break;
        case T_SeqScan:
            return "SeqScan";
            break;