Fix advertised dispsize for libpq's sslmode connection parameter.
authorTom Lane <[email protected]>
Mon, 17 Mar 2014 01:43:57 +0000 (21:43 -0400)
committerTom Lane <[email protected]>
Mon, 17 Mar 2014 01:43:57 +0000 (21:43 -0400)
"8" was correct back when "disable" was the longest allowed value, but
since "verify-full" was added, it should be "12".  Given the lack of
complaints, I wouldn't be surprised if nobody is actually using these
values ... but still, if they're in the API, they should be right.

Noticed while pursuing a different problem.  It's been wrong for quite
a long time, so back-patch to all supported branches.

src/interfaces/libpq/fe-connect.c

index e0636167f4d9a11537cf579b7d040f3f0b5058a2..728e0fd106ac1b1f25e877cbe937bfcda96b77b5 100644 (file)
@@ -181,7 +181,7 @@ static const PQconninfoOption PQconninfoOptions[] = {
     * to exclude them since none of them are mandatory.
     */
    {"sslmode", "PGSSLMODE", DefaultSSLMode, NULL,
-   "SSL-Mode", "", 8},         /* sizeof("disable") == 8 */
+   "SSL-Mode", "", 12},            /* sizeof("verify-full") == 12 */
 
    {"sslcert", "PGSSLCERT", NULL, NULL,
    "SSL-Client-Cert", "", 64},