Avoid file descriptor leak in pg_test_fsync.
authorRobert Haas <[email protected]>
Wed, 19 Nov 2014 16:57:54 +0000 (11:57 -0500)
committerRobert Haas <[email protected]>
Wed, 19 Nov 2014 17:06:24 +0000 (12:06 -0500)
This can cause problems on Windows, where files that are still open
can't be unlinked.

Jeff Janes

contrib/pg_test_fsync/pg_test_fsync.c

index 3352f046dcad70a329aac52067bfbec66abb036a..c8427623d20bc0275111c4ba0b0f70c959d7d636 100644 (file)
@@ -258,8 +258,6 @@ test_sync(int writes_per_op)
    }
    else
    {
-       if ((tmpfile = open(filename, O_RDWR | O_DSYNC | PG_O_DIRECT, 0)) == -1)
-           die("could not open output file");
        START_TIMER;
        for (ops = 0; alarm_triggered == false; ops++)
        {