Remove StoreSingleInheritance reimplementation
authorAlvaro Herrera <[email protected]>
Thu, 25 Mar 2021 13:47:38 +0000 (10:47 -0300)
committerAlvaro Herrera <[email protected]>
Thu, 25 Mar 2021 13:47:38 +0000 (10:47 -0300)
I introduced this duplicate code in commit 8b08f7d4820f for no good
reason.  Remove it, and backpatch to 11 where it was introduced.

Author: Álvaro Herrera <[email protected]>

src/backend/commands/indexcmds.c

index 8bc652ecd39c401cfff2855013f294e54a33db3a..e4e1bbb7e00bffda25fad94e1fda79493e8a930d 100644 (file)
@@ -4062,23 +4062,7 @@ IndexSetParentIndex(Relation partitionIdx, Oid parentOid)
        }
        else
        {
-           Datum       values[Natts_pg_inherits];
-           bool        isnull[Natts_pg_inherits];
-
-           /*
-            * No pg_inherits row exists, and we want a parent for this index,
-            * so insert it.
-            */
-           values[Anum_pg_inherits_inhrelid - 1] = ObjectIdGetDatum(partRelid);
-           values[Anum_pg_inherits_inhparent - 1] =
-               ObjectIdGetDatum(parentOid);
-           values[Anum_pg_inherits_inhseqno - 1] = Int32GetDatum(1);
-           memset(isnull, false, sizeof(isnull));
-
-           tuple = heap_form_tuple(RelationGetDescr(pg_inherits),
-                                   values, isnull);
-           CatalogTupleInsert(pg_inherits, tuple);
-
+           StoreSingleInheritance(partRelid, parentOid, 1);
            fix_dependencies = true;
        }
    }