Remove useless casts

Maybe these are left from when PageGetItem() was a macro, but now they
are clearly useless.

diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 7dad7af4db42bd86eb25c38891903d90b5659537..6eff40a315dc48b331e535235582db3dc46bded1 100644 (file)
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
@@ -461,7 +461,7 @@ heapgetpage(TableScanDesc sscan, BlockNumber page)
            bool        valid;
 
            loctup.t_tableOid = RelationGetRelid(scan->rs_base.rs_rd);
-           loctup.t_data = (HeapTupleHeader) PageGetItem((Page) dp, lpp);
+           loctup.t_data = (HeapTupleHeader) PageGetItem(dp, lpp);
            loctup.t_len = ItemIdGetLength(lpp);
            ItemPointerSet(&(loctup.t_self), page, lineoff);
 
@@ -677,7 +677,7 @@ heapgettup(HeapScanDesc scan,
        lpp = PageGetItemId(dp, lineoff);
        Assert(ItemIdIsNormal(lpp));
 
-       tuple->t_data = (HeapTupleHeader) PageGetItem((Page) dp, lpp);
+       tuple->t_data = (HeapTupleHeader) PageGetItem(dp, lpp);
        tuple->t_len = ItemIdGetLength(lpp);
 
        return;
@@ -703,7 +703,7 @@ heapgettup(HeapScanDesc scan,
            {
                bool        valid;
 
-               tuple->t_data = (HeapTupleHeader) PageGetItem((Page) dp, lpp);
+               tuple->t_data = (HeapTupleHeader) PageGetItem(dp, lpp);
                tuple->t_len = ItemIdGetLength(lpp);
                ItemPointerSet(&(tuple->t_self), page, lineoff);
 
@@ -1002,7 +1002,7 @@ heapgettup_pagemode(HeapScanDesc scan,
        lpp = PageGetItemId(dp, lineoff);
        Assert(ItemIdIsNormal(lpp));
 
-       tuple->t_data = (HeapTupleHeader) PageGetItem((Page) dp, lpp);
+       tuple->t_data = (HeapTupleHeader) PageGetItem(dp, lpp);
        tuple->t_len = ItemIdGetLength(lpp);
 
        /* check that rs_cindex is in sync */
@@ -1024,7 +1024,7 @@ heapgettup_pagemode(HeapScanDesc scan,
            lpp = PageGetItemId(dp, lineoff);
            Assert(ItemIdIsNormal(lpp));
 
-           tuple->t_data = (HeapTupleHeader) PageGetItem((Page) dp, lpp);
+           tuple->t_data = (HeapTupleHeader) PageGetItem(dp, lpp);
            tuple->t_len = ItemIdGetLength(lpp);
            ItemPointerSet(&(tuple->t_self), page, lineoff);
 

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 41f1ca65d0143b29dc4a8cc6d62f0b2b46abd01b..103ddbd9788bdb51673d73c5f9a55133f3bb30d0 100644 (file)
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -2193,7 +2193,7 @@ heapam_scan_bitmap_next_block(TableScanDesc scan,
            lp = PageGetItemId(dp, offnum);
            if (!ItemIdIsNormal(lp))
                continue;
-           loctup.t_data = (HeapTupleHeader) PageGetItem((Page) dp, lp);
+           loctup.t_data = (HeapTupleHeader) PageGetItem(dp, lp);
            loctup.t_len = ItemIdGetLength(lp);
            loctup.t_tableOid = scan->rs_rd->rd_id;
            ItemPointerSet(&loctup.t_self, page, offnum);
@@ -2238,7 +2238,7 @@ heapam_scan_bitmap_next_tuple(TableScanDesc scan,
    lp = PageGetItemId(dp, targoffset);
    Assert(ItemIdIsNormal(lp));
 
-   hscan->rs_ctup.t_data = (HeapTupleHeader) PageGetItem((Page) dp, lp);
+   hscan->rs_ctup.t_data = (HeapTupleHeader) PageGetItem(dp, lp);
    hscan->rs_ctup.t_len = ItemIdGetLength(lp);
    hscan->rs_ctup.t_tableOid = scan->rs_rd->rd_id;
    ItemPointerSet(&hscan->rs_ctup.t_self, hscan->rs_cblock, targoffset);