Change sort order for reviewers/authors in filter dropdown

Previously it was sorted by last name, which did not always make sense.
Canged to sort by first name, which hopefully makes more sense.

Per request from Alvaro Herrera and others.

diff --git a/pgcommitfest/commitfest/forms.py b/pgcommitfest/commitfest/forms.py
index 29ab2afbc96dc7c35fa121647b3099838b4b6aa5..568af642e723274f40c4f29030a61c255ce9a083 100644 (file)
--- a/pgcommitfest/commitfest/forms.py
+++ b/pgcommitfest/commitfest/forms.py
@@ -28,7 +28,7 @@ class CommitFestFilterForm(forms.Form):
                self.fields['status'] = forms.ChoiceField(choices=c, required=False)
 
                q = Q(patch_author__commitfests=cf) | Q(patch_reviewer__commitfests=cf)
-               userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct().order_by('last_name', 'first_name')]
+               userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct().order_by('first_name', 'last_name')]
                self.fields['author'] = forms.ChoiceField(choices=userchoices, required=False)
                self.fields['reviewer'] = forms.ChoiceField(choices=userchoices, required=False)