Move call to GetTopTransactionId() earlier in LockAcquire(),

removing an infrequently occurring race condition in Hot Standby.
An xid must be assigned before a lock appears in shared memory,
rather than immediately after, else GetRunningTransactionLocks()
may see InvalidTransactionId, causing assertion failures during
lock processing on standby.

Bug report and diagnosis by Fujii Masao, fix by me.

diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
index 82da9261566e8d362df294de655c29fe6db479d3..5e0d1d067e510b25c5e3bd5bedffc8efb16fec26 100644 (file)
--- a/src/backend/storage/ipc/standby.c
+++ b/src/backend/storage/ipc/standby.c
@@ -953,14 +953,6 @@ LogAccessExclusiveLock(Oid dbOid, Oid relOid)
 {
    xl_standby_lock xlrec;
 
-   /*
-    * Ensure that a TransactionId has been assigned to this transaction. We
-    * don't actually need the xid yet but if we don't do this then
-    * RecordTransactionCommit() and RecordTransactionAbort() will optimise
-    * away the transaction completion record which recovery relies upon to
-    * release locks. It's a hack, but for a corner case not worth adding code
-    * for into the main commit path.
-    */
    xlrec.xid = GetTopTransactionId();
 
    /*
@@ -973,3 +965,24 @@ LogAccessExclusiveLock(Oid dbOid, Oid relOid)
 
    LogAccessExclusiveLocks(1, &xlrec);
 }
+
+/*
+ * Prepare to log an AccessExclusiveLock, for use during LockAcquire()
+ */
+void
+LogAccessExclusiveLockPrepare(void)
+{
+   /*
+    * Ensure that a TransactionId has been assigned to this transaction,
+    * for two reasons, both related to lock release on the standby.
+    * First, we must assign an xid so that RecordTransactionCommit() and
+    * RecordTransactionAbort() do not optimise away the transaction
+    * completion record which recovery relies upon to release locks. It's
+    * a hack, but for a corner case not worth adding code for into the
+    * main commit path. Second, must must assign an xid before the lock
+    * is recorded in shared memory, otherwise a concurrently executing
+    * GetRunningTransactionLocks() might see a lock associated with an
+    * InvalidTransactionId which we later assert cannot happen.
+    */
+   (void) GetTopTransactionId();
+}

diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
index 45cfbc071026aeac8b87ef81ef9ba8b29fed63a0..e7cf1cd7ad00372b7944022d6ed85da4a134fe56 100644 (file)
--- a/src/backend/storage/lmgr/lock.c
+++ b/src/backend/storage/lmgr/lock.c
@@ -499,6 +499,7 @@ LockAcquireExtended(const LOCKTAG *locktag,
    int         partition;
    LWLockId    partitionLock;
    int         status;
+   bool        log_lock = false;
 
    if (lockmethodid <= 0 || lockmethodid >= lengthof(LockMethods))
        elog(ERROR, "unrecognized lock method: %d", lockmethodid);
@@ -579,6 +580,24 @@ LockAcquireExtended(const LOCKTAG *locktag,
        return LOCKACQUIRE_ALREADY_HELD;
    }
 
+   /*
+    * Emit a WAL record if acquisition of this lock needs to be replayed in a
+    * standby server. Only AccessExclusiveLocks can conflict with lock types
+    * that read-only transactions can acquire in a standby server.
+    *
+    * Make sure this definition matches the one in GetRunningTransactionLocks().
+    *
+    * First we prepare to log, then after lock acquired we issue log record.
+    */
+   if (lockmode >= AccessExclusiveLock &&
+       locktag->locktag_type == LOCKTAG_RELATION &&
+       !RecoveryInProgress() &&
+       XLogStandbyInfoActive())
+   {
+       LogAccessExclusiveLockPrepare();
+       log_lock = true;
+   }
+
    /*
     * Otherwise we've got to mess with the shared lock table.
     */
@@ -868,15 +887,9 @@ LockAcquireExtended(const LOCKTAG *locktag,
 
    /*
     * Emit a WAL record if acquisition of this lock need to be replayed in a
-    * standby server. Only AccessExclusiveLocks can conflict with lock types
-    * that read-only transactions can acquire in a standby server.
-    *
-    * Make sure this definition matches the one GetRunningTransactionLocks().
+    * standby server.
     */
-   if (lockmode >= AccessExclusiveLock &&
-       locktag->locktag_type == LOCKTAG_RELATION &&
-       !RecoveryInProgress() &&
-       XLogStandbyInfoActive())
+   if (log_lock)
    {
        /*
         * Decode the locktag back to the original values, to avoid sending

diff --git a/src/include/storage/standby.h b/src/include/storage/standby.h
index 553415c2d3a452ce2aca3497b67f04fb7e9cc652..dec1d7132339656c1016ceb8a15f4a4221d1fd1e 100644 (file)
--- a/src/include/storage/standby.h
+++ b/src/include/storage/standby.h
@@ -109,6 +109,7 @@ typedef struct RunningTransactionsData
 typedef RunningTransactionsData *RunningTransactions;
 
 extern void LogAccessExclusiveLock(Oid dbOid, Oid relOid);
+extern void LogAccessExclusiveLockPrepare(void);
 
 extern void LogStandbySnapshot(TransactionId *oldestActiveXid, TransactionId *nextXid);