Fix mdtruncate() to close fd.c handle of deleted segments.

mdtruncate() forgot to FileClose() a segment's mdfd_vfd, when deleting
it. That lead to a fd.c handle to a truncated file being kept open until
backend exit.

The issue appears to have been introduced way back in 1a5c450f3024ac5,
before that the handle was closed inside FileUnlink().

The impact of this bug is limited - only VACUUM and ON COMMIT TRUNCATE
for temporary tables, truncate files in place (i.e. TRUNCATE itself is
not affected), and the relation has to be bigger than 1GB. The
consequences of a leaked fd.c handle aren't severe either.

Discussion: <20160908220748[email protected]>
Backpatch: all supported releases

diff --git a/src/backend/storage/smgr/md.c b/src/backend/storage/smgr/md.c
index 3005a22b2d896f0cd1e8b77ac586aae64d391e53..31b20fff7e45bb594eabb85138bd1b49d8efe334 100644 (file)
--- a/src/backend/storage/smgr/md.c
+++ b/src/backend/storage/smgr/md.c
@@ -895,6 +895,7 @@ mdtruncate(SMgrRelation reln, ForkNumber forknum, BlockNumber nblocks)
                        v = v->mdfd_chain;
                        Assert(ov != reln->md_fd[forknum]); /* we never drop the 1st
                                                                                                 * segment */
+                       FileClose(ov->mdfd_vfd);
                        pfree(ov);
                }
                else if (priorblocks + ((BlockNumber) RELSEG_SIZE) > nblocks)