From: Heikki Linnakangas Date: Sun, 9 Mar 2025 18:40:45 +0000 (+0200) Subject: Fix incorrect assertion in libpqwalreceiver X-Git-Tag: REL_18_BETA1~638 X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=03f8e9a7fee0ad4d87bfe48cb22dbca08fd8e6c4;p=postgresql.git Fix incorrect assertion in libpqwalreceiver Was supposed to check the length of the array, but was checking its size in bytes. Author: Jacob Brazeal Discussion: https://www.postgresql.org/message-id/CA%2BCOZaA_9afJxj9ZuO73U5P7WXP%2BZM9NGnZvTDCmBFz0FGP%2BwA@mail.gmail.com --- diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c index 1b158c9d288..c650935ef5d 100644 --- a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c +++ b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c @@ -208,7 +208,7 @@ libpqrcv_connect(const char *conninfo, bool replication, bool logical, keys[++i] = NULL; vals[i] = NULL; - Assert(i < sizeof(keys)); + Assert(i < lengthof(keys)); conn = palloc0(sizeof(WalReceiverConn)); conn->streamConn = PQconnectStartParams(keys, vals,