From: Tom Lane Date: Sun, 3 Jul 2022 19:27:27 +0000 (-0400) Subject: Simplify tab completion of extension versions, redux. X-Git-Tag: REL_16_BETA1~2369 X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=22a67fdd5d2756860e0e0813e4a1ae11b69e21c7;p=postgresql.git Simplify tab completion of extension versions, redux. After commit 662dbe2c8, psql tab completion didn't conveniently support the case of "ALTER EXTENSION foo UPDATE". It'd always add "TO", which is fine if you want to specify a target version but not if you don't ... and surely the latter is the much more common case. To fix, remove "TO" from the initially offered completion; you now need to press TAB one additional time to get that. We won't try to duplicate the old behavior of attempting initial completion on the target version along with TO. It's too squirrelly to get the quoting right, and this is such an infrequent usage that it doesn't seem worth expending a lot of effort and special code on. Noted by Noah Misch. Back-patch to v15. Discussion: https://postgr.es/m/20220703083217.GB2476530@rfd.leadboat.com --- diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c index 463cac9fb07..c5cafe6f4bf 100644 --- a/src/bin/psql/tab-complete.c +++ b/src/bin/psql/tab-complete.c @@ -1927,7 +1927,7 @@ psql_completion(const char *text, int start, int end) /* ALTER EXTENSION */ else if (Matches("ALTER", "EXTENSION", MatchAny)) - COMPLETE_WITH("ADD", "DROP", "UPDATE TO", "SET SCHEMA"); + COMPLETE_WITH("ADD", "DROP", "UPDATE", "SET SCHEMA"); /* ALTER EXTENSION UPDATE */ else if (Matches("ALTER", "EXTENSION", MatchAny, "UPDATE"))