From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 18 Mar 2025 14:54:10 +0000 (-0400)
Subject: Silence compiler warning.
X-Git-Tag: REL_18_BETA1~536
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=4078da6c478039bbafdd58138957dc47db545935;p=postgresql.git

Silence compiler warning.

Assorted buildfarm members are complaining about "'process_list' may
be used uninitialized in this function" since f76892c9f, presumably
because they don't trust that the switch case labels are exhaustive.
We can silence that by initializing the variable to NULL.  Should
a switch fall-through actually happen, we'll get SIGSEGV at the
first use, which is as good as an Assert.
---

diff --git a/src/bin/scripts/reindexdb.c b/src/bin/scripts/reindexdb.c
index 7f0fc6344e9..860a0fcb46b 100644
--- a/src/bin/scripts/reindexdb.c
+++ b/src/bin/scripts/reindexdb.c
@@ -286,7 +286,7 @@ reindex_one_database(ConnParams *cparams, ReindexType type,
 	SimpleStringListCell *cell;
 	SimpleOidListCell *indices_tables_cell = NULL;
 	bool		parallel = concurrentCons > 1;
-	SimpleStringList *process_list;
+	SimpleStringList *process_list = NULL;
 	SimpleOidList *tableoid_list = NULL;
 	ReindexType process_type = type;
 	ParallelSlotArray *sa;