From: Robert Haas <rhaas@postgresql.org>
Date: Mon, 28 Sep 2015 14:47:05 +0000 (-0400)
Subject: Don't try to create a temp install without abs_top_builddir.
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=45e5b4ef5c392ddfcd72693f65659bafdda7ee1b;p=users%2Frhaas%2Fpostgres.git

Don't try to create a temp install without abs_top_builddir.

Otherwise, we effectively act as if abs_top_builddir were the root
directory, which is quite dangerous if the user happens to have
permissions to do things there.  This can crop up in PGXS builds,
for example.

Report by Sandro Santilli, patch by me, review by Noah Misch.
---

diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 6871c3c614..74ffcbf2f1 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -320,6 +320,7 @@ check: temp-install
 .PHONY: temp-install
 temp-install:
 ifndef NO_TEMP_INSTALL
+ifneq ($(abs_top_builddir),)
 ifeq ($(MAKELEVEL),0)
 	rm -rf '$(abs_top_builddir)'/tmp_install
 	$(MKDIR_P) '$(abs_top_builddir)'/tmp_install/log
@@ -327,6 +328,7 @@ ifeq ($(MAKELEVEL),0)
 endif
 	$(if $(EXTRA_INSTALL),for extra in $(EXTRA_INSTALL); do $(MAKE) -C '$(top_builddir)'/$$extra DESTDIR='$(abs_top_builddir)'/tmp_install install >>'$(abs_top_builddir)'/tmp_install/log/install.log || exit; done)
 endif
+endif
 
 PROVE = @PROVE@
 PG_PROVE_FLAGS = -I $(top_srcdir)/src/test/perl/