From: Noah Misch <noah@leadboat.com>
Date: Sat, 10 May 2025 14:36:27 +0000 (-0700)
Subject: Remove GLOBALTABLESPACE_OID assert for locked buffers.
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=4a4ee0c2c1e53401924101945ac3d517c0a8a559;p=postgresql.git

Remove GLOBALTABLESPACE_OID assert for locked buffers.

Commit f4ece891fc2f3f96f0571720a1ae30db8030681b added the assertion in
an attempt to catch some defects even after VACUUM FULL or REINDEX.
However, IsCatalogTextUniqueIndexOid(tag.relNumber) always returns false
after a relfilenode change, provoking unintended assertion failures.

Reported-by: Adam Guo <adamguo@amazon.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Bug: #18912
Discussion: https://postgr.es/m/18912-a41c9bd0e0ad19b1@postgresql.org
---

diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 0b317d2d809..f93131a645e 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -4161,8 +4161,6 @@ AssertNotCatalogBufferLock(LWLock *lock, LWLockMode mode,
 		return;
 
 	Assert(!IsCatalogRelationOid(relid));
-	/* Shared rels are always catalogs: detect even after VACUUM FULL. */
-	Assert(tag.spcOid != GLOBALTABLESPACE_OID);
 }
 #endif