From: Alexander Korotkov <akorotkov@postgresql.org>
Date: Wed, 17 Jan 2024 21:16:53 +0000 (+0200)
Subject: Remove the flaky check in event_trigger_login regression test
X-Git-Tag: REL_17_BETA1~1087
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=4b885d01f9676f62d8b8156e45282c631181369f;p=postgresql.git

Remove the flaky check in event_trigger_login regression test

The query checks that pg_database.dathasloginevt is unset on connect when
there are no event triggers.  However, unsetting this flag is implemented in
a non-blocking way, so a concurrent autovacuum connection breaks this check.
It doesn't seem we can do much with this, at least within a regression test.
So, remove it.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/44807d19-81a6-3884-3e0f-22dd99aac3ed%40gmail.com
---

diff --git a/src/test/regress/expected/event_trigger_login.out b/src/test/regress/expected/event_trigger_login.out
index 174879578be..4f43c2352f6 100644
--- a/src/test/regress/expected/event_trigger_login.out
+++ b/src/test/regress/expected/event_trigger_login.out
@@ -37,9 +37,3 @@ DROP TABLE user_logins;
 DROP EVENT TRIGGER on_login_trigger;
 DROP FUNCTION on_login_proc();
 \c
-SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';
- dathasloginevt 
-----------------
- f
-(1 row)
-
diff --git a/src/test/regress/sql/event_trigger_login.sql b/src/test/regress/sql/event_trigger_login.sql
index b8e39f75261..060c105e609 100644
--- a/src/test/regress/sql/event_trigger_login.sql
+++ b/src/test/regress/sql/event_trigger_login.sql
@@ -22,4 +22,3 @@ DROP TABLE user_logins;
 DROP EVENT TRIGGER on_login_trigger;
 DROP FUNCTION on_login_proc();
 \c
-SELECT dathasloginevt FROM pg_database WHERE datname= :'DBNAME';