From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 6 Jul 2022 21:26:27 +0000 (-0400)
Subject: Fix wrong field order in _readMergeWhenClause().
X-Git-Tag: REL_16_BETA1~2333
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=55b8ac81723c45dca95d4ad4892a1ee28db37c23;p=postgresql.git

Fix wrong field order in _readMergeWhenClause().

We hadn't noticed this because it's dead code: there is no
situation where we read raw parse trees from text format.
So maybe the right fix is to remove the function altogether,
but I'll forbear for now; it's not the only dead code in
readfuncs.c, I think.

Noted while comparing existing code to the results of
Peter's auto-generation script.
---

diff --git a/src/backend/nodes/readfuncs.c b/src/backend/nodes/readfuncs.c
index 6a05b694152..014b3005af8 100644
--- a/src/backend/nodes/readfuncs.c
+++ b/src/backend/nodes/readfuncs.c
@@ -485,10 +485,10 @@ _readMergeWhenClause(void)
 
 	READ_BOOL_FIELD(matched);
 	READ_ENUM_FIELD(commandType, CmdType);
+	READ_ENUM_FIELD(override, OverridingKind);
 	READ_NODE_FIELD(condition);
 	READ_NODE_FIELD(targetList);
 	READ_NODE_FIELD(values);
-	READ_ENUM_FIELD(override, OverridingKind);
 
 	READ_DONE();
 }