From: Andrew Dunstan <andrew@dunslane.net>
Date: Sat, 15 Mar 2025 21:41:54 +0000 (-0400)
Subject: Silence perl critic
X-Git-Tag: REL_18_BETA1~570
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=5eabd91a83adae75f53b61857343660919fef4c7;p=postgresql.git

Silence perl critic

Commit 27bdec06841 uses a loop variable that is not strictly local to
the loop. Perlcritic disapproves, and there's really no reason as the
variable is not used outside the loop.

Per buildfarm animals koel and crake.
---

diff --git a/src/common/unicode/generate-unicode_case_table.pl b/src/common/unicode/generate-unicode_case_table.pl
index 3c2edc7ca4d..ddd0980719b 100644
--- a/src/common/unicode/generate-unicode_case_table.pl
+++ b/src/common/unicode/generate-unicode_case_table.pl
@@ -619,7 +619,7 @@ sub branch
 sub make_ranges
 {
 	my ($nums, $limit) = @_;
-	my ($prev, $start, $curr, $total, @sorted, @range);
+	my ($prev, $start, $total, @sorted, @range);
 
 	@sorted = sort { $a <=> $b } @$nums;
 
@@ -635,7 +635,7 @@ sub make_ranges
 	# append final 'undef' to signal final iteration
 	push @sorted, undef;
 
-	foreach $curr (@sorted)
+	foreach my $curr (@sorted)
 	{
 		# if last iteration always append the range
 		if (!defined($curr) || ($curr - $prev > $limit))