From: Dean Rasheed <dean.a.rasheed@gmail.com>
Date: Mon, 26 Aug 2024 10:00:20 +0000 (+0100)
Subject: Fix compiler warning in mul_var_short().
X-Git-Tag: REL_18_BETA1~2051
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=7cac6307a43c1fcbd050724d3995a489da62e852;p=postgresql.git

Fix compiler warning in mul_var_short().

Some compilers (e.g., gcc before version 7) mistakenly think "carry"
might be used uninitialized.

Reported by Tom Lane, per various buildfarm members, e.g. arowana.
---

diff --git a/src/backend/utils/adt/numeric.c b/src/backend/utils/adt/numeric.c
index 44d88e90079..15b517ba988 100644
--- a/src/backend/utils/adt/numeric.c
+++ b/src/backend/utils/adt/numeric.c
@@ -8969,7 +8969,7 @@ mul_var_short(const NumericVar *var1, const NumericVar *var2,
 	int			res_ndigits;
 	NumericDigit *res_buf;
 	NumericDigit *res_digits;
-	uint32		carry;
+	uint32		carry = 0;
 	uint32		term;
 
 	/* Check preconditions */
@@ -9018,7 +9018,6 @@ mul_var_short(const NumericVar *var1, const NumericVar *var2,
 			 *		res_ndigits = var2ndigits + 1
 			 * ----------
 			 */
-			carry = 0;
 			for (int i = var2ndigits - 1; i >= 0; i--)
 			{
 				term = PRODSUM1(var1digits, 0, var2digits, i) + carry;