From: Nathan Bossart <nathan@postgresql.org>
Date: Wed, 19 Jun 2024 21:12:18 +0000 (-0500)
Subject: Fix comment in pg_upgrade.h.
X-Git-Tag: REL_17_BETA2~25
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=832dc19ea681a54c153228a96112bea68dbff022;p=postgresql.git

Fix comment in pg_upgrade.h.

Contrary to what the comment for the "check" struct member claims,
'pg_upgrade --check' performs only the checks and does not ask the
user for permission to make changes.

Reviewed-by: Daniel Gustafsson
Discussion: https://postgr.es/m/ZnHk7ci5IuTWVc_c%40nathan
---

diff --git a/src/bin/pg_upgrade/pg_upgrade.h b/src/bin/pg_upgrade/pg_upgrade.h
index 92bcb693fbf..8afe240bdfb 100644
--- a/src/bin/pg_upgrade/pg_upgrade.h
+++ b/src/bin/pg_upgrade/pg_upgrade.h
@@ -321,8 +321,7 @@ typedef struct
 */
 typedef struct
 {
-	bool		check;			/* true -> ask user for permission to make
-								 * changes */
+	bool		check;			/* check clusters only, don't change any data */
 	bool		do_sync;		/* flush changes to disk */
 	transferMode transfer_mode; /* copy files or link them? */
 	int			jobs;			/* number of processes/threads to use */