From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 19 Nov 2014 16:57:54 +0000 (-0500)
Subject: Avoid file descriptor leak in pg_test_fsync.
X-Git-Tag: REL9_5_ALPHA1~1184
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=a0165553619107f990cb7872f4a9573598319581;p=postgresql.git

Avoid file descriptor leak in pg_test_fsync.

This can cause problems on Windows, where files that are still open
can't be unlinked.

Jeff Janes
---

diff --git a/contrib/pg_test_fsync/pg_test_fsync.c b/contrib/pg_test_fsync/pg_test_fsync.c
index 3352f046dca..c8427623d20 100644
--- a/contrib/pg_test_fsync/pg_test_fsync.c
+++ b/contrib/pg_test_fsync/pg_test_fsync.c
@@ -258,8 +258,6 @@ test_sync(int writes_per_op)
 	}
 	else
 	{
-		if ((tmpfile = open(filename, O_RDWR | O_DSYNC | PG_O_DIRECT, 0)) == -1)
-			die("could not open output file");
 		START_TIMER;
 		for (ops = 0; alarm_triggered == false; ops++)
 		{