From: Tom Lane Date: Mon, 1 Jul 2024 03:20:57 +0000 (-0400) Subject: Further weaken new pg_createsubscriber test on Windows. X-Git-Tag: REL_18_BETA1~2518 X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=a1333ec048fb95ff47a5fc10a9cfde69fdbd2b01;p=postgresql.git Further weaken new pg_createsubscriber test on Windows. Also omit backslashes (\) in the generated database names on Windows. As before, perhaps we can revert this after updating affected buildfarm animals. Discussion: https://postgr.es/m/2509767.1719773880@sss.pgh.pa.us --- diff --git a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl index 8e8d3f0a02a..1241bf6c6a7 100644 --- a/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl +++ b/src/bin/pg_basebackup/t/040_pg_createsubscriber.pl @@ -30,8 +30,9 @@ sub generate_db $dbname .= $suffix; - # Old IPC::Run mis-quotes command line arguments containing '"' on Windows - $dbname =~ tr/\"//d if ($windows_os); + # On Windows, older IPC::Run versions can mis-quote command line arguments + # containing double quote or backslash + $dbname =~ tr/\"\\//d if ($windows_os); $node->command_ok( [ 'createdb', $dbname ],