From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Fri, 11 Oct 2024 08:09:09 +0000 (+0300)
Subject: Mark consume_xids test functions VOLATILE and PARALLEL UNSAFE
X-Git-Tag: REL_18_BETA1~1737
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=add77755ce851fae2f72be4b9c56a606f9362895;p=postgresql.git

Mark consume_xids test functions VOLATILE and PARALLEL UNSAFE

Both functions advance the transaction ID, which modifies the system
state. Thus, they should be marked as VOLATILE.

Additionally, they call the AssignTransactionId function, which cannot
be invoked in parallel mode, so they should be marked as PARALLEL
UNSAFE.

Author: Yushi Ogiwara <btogiwarayuushi@oss.nttdata.com>
Discussion: https://www.postgresql.org/message-id/18f01e4fd46448f88c7a1363050a9955@oss.nttdata.com
---

diff --git a/src/test/modules/xid_wraparound/xid_wraparound--1.0.sql b/src/test/modules/xid_wraparound/xid_wraparound--1.0.sql
index 51d25fc4c63..96356b4b974 100644
--- a/src/test/modules/xid_wraparound/xid_wraparound--1.0.sql
+++ b/src/test/modules/xid_wraparound/xid_wraparound--1.0.sql
@@ -4,9 +4,9 @@
 \echo Use "CREATE EXTENSION xid_wraparound" to load this file. \quit
 
 CREATE FUNCTION consume_xids(nxids bigint)
-RETURNS xid8 IMMUTABLE PARALLEL SAFE STRICT
+RETURNS xid8 VOLATILE PARALLEL UNSAFE STRICT
 AS 'MODULE_PATHNAME' LANGUAGE C;
 
 CREATE FUNCTION consume_xids_until(targetxid xid8)
-RETURNS xid8 IMMUTABLE PARALLEL SAFE STRICT
+RETURNS xid8 VOLATILE PARALLEL UNSAFE STRICT
 AS 'MODULE_PATHNAME' LANGUAGE C;