From: Tomas Vondra <tomas@2ndquadrant.com>
Date: Wed, 30 Aug 2017 23:18:00 +0000 (+0200)
Subject: Remove FDW objects from tests in pg_visibility contrib module
X-Git-Tag: XL_10_R1BETA1~134
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=af59f510589031e22e71b6c8214944614332c225;p=postgres-xl.git

Remove FDW objects from tests in pg_visibility contrib module

Postgres-XL does not support FWD object, so the tests were failing
with "does not exist" errors, instead of testing that visibility on
FDW objects is not supported. So just remove the few test queries.
---

diff --git a/contrib/pg_visibility/expected/pg_visibility.out b/contrib/pg_visibility/expected/pg_visibility.out
index f0dcb897c4..c914307c0e 100644
--- a/contrib/pg_visibility/expected/pg_visibility.out
+++ b/contrib/pg_visibility/expected/pg_visibility.out
@@ -52,20 +52,6 @@ select pg_check_frozen('test_sequence');
 ERROR:  "test_sequence" is not a table, materialized view, or TOAST table
 select pg_truncate_visibility_map('test_sequence');
 ERROR:  "test_sequence" is not a table, materialized view, or TOAST table
-create foreign data wrapper dummy;
-create server dummy_server foreign data wrapper dummy;
-create foreign table test_foreign_table () server dummy_server;
--- foreign tables do not have VMs, so these all fail
-select pg_visibility('test_foreign_table', 0);
-ERROR:  "test_foreign_table" is not a table, materialized view, or TOAST table
-select pg_visibility_map('test_foreign_table');
-ERROR:  "test_foreign_table" is not a table, materialized view, or TOAST table
-select pg_visibility_map_summary('test_foreign_table');
-ERROR:  "test_foreign_table" is not a table, materialized view, or TOAST table
-select pg_check_frozen('test_foreign_table');
-ERROR:  "test_foreign_table" is not a table, materialized view, or TOAST table
-select pg_truncate_visibility_map('test_foreign_table');
-ERROR:  "test_foreign_table" is not a table, materialized view, or TOAST table
 -- check some of the allowed relkinds
 create table regular_table (a int);
 insert into regular_table values (1), (2);
@@ -135,8 +121,5 @@ select pg_truncate_visibility_map('test_partition');
 drop table test_partitioned;
 drop view test_view;
 drop sequence test_sequence;
-drop foreign table test_foreign_table;
-drop server dummy_server;
-drop foreign data wrapper dummy;
 drop materialized view matview_visibility_test;
 drop table regular_table;
diff --git a/contrib/pg_visibility/sql/pg_visibility.sql b/contrib/pg_visibility/sql/pg_visibility.sql
index c2a7f1d9e4..992a9ef88f 100644
--- a/contrib/pg_visibility/sql/pg_visibility.sql
+++ b/contrib/pg_visibility/sql/pg_visibility.sql
@@ -38,16 +38,6 @@ select pg_visibility_map_summary('test_sequence');
 select pg_check_frozen('test_sequence');
 select pg_truncate_visibility_map('test_sequence');
 
-create foreign data wrapper dummy;
-create server dummy_server foreign data wrapper dummy;
-create foreign table test_foreign_table () server dummy_server;
--- foreign tables do not have VMs, so these all fail
-select pg_visibility('test_foreign_table', 0);
-select pg_visibility_map('test_foreign_table');
-select pg_visibility_map_summary('test_foreign_table');
-select pg_check_frozen('test_foreign_table');
-select pg_truncate_visibility_map('test_foreign_table');
-
 -- check some of the allowed relkinds
 create table regular_table (a int);
 insert into regular_table values (1), (2);
@@ -76,8 +66,5 @@ select pg_truncate_visibility_map('test_partition');
 drop table test_partitioned;
 drop view test_view;
 drop sequence test_sequence;
-drop foreign table test_foreign_table;
-drop server dummy_server;
-drop foreign data wrapper dummy;
 drop materialized view matview_visibility_test;
 drop table regular_table;