From: Peter Geoghegan <pg@bowt.ie>
Date: Mon, 19 Sep 2022 22:47:04 +0000 (-0700)
Subject: Consistently use named parameters in regex code consistently.
X-Git-Tag: REL_16_BETA1~1676
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=cb8ff7ed5ac907a4a574413f3e46a3522d7b164c;p=postgresql.git

Consistently use named parameters in regex code consistently.

Adjust a handful of remaining function prototypes that were overlooked
by recent commit bc2187ed.  This oversight wasn't caught by clang-tidy
because the functions in question are only built in custom REG_DEBUG
builds.

Author: Peter Geoghegan <pg@bowt.ie>
Reported-By: Tom Lane <tgl@sss.pgh.pa.us>
---

diff --git a/src/backend/regex/regcomp.c b/src/backend/regex/regcomp.c
index e6ff3653a77..bb8c2405989 100644
--- a/src/backend/regex/regcomp.c
+++ b/src/backend/regex/regcomp.c
@@ -234,11 +234,11 @@ static void freecnfa(struct cnfa *cnfa);
 static void dumpnfa(struct nfa *nfa, FILE *f);
 
 #ifdef REG_DEBUG
-static void dumpstate(struct state *, FILE *);
-static void dumparcs(struct state *, FILE *);
-static void dumparc(struct arc *, struct state *, FILE *);
-static void dumpcnfa(struct cnfa *, FILE *);
-static void dumpcstate(int, struct cnfa *, FILE *);
+static void dumpstate(struct state *s, FILE *f);
+static void dumparcs(struct state *s, FILE *f);
+static void dumparc(struct arc *a, struct state *s, FILE *f);
+static void dumpcnfa(struct cnfa *cnfa, FILE *f);
+static void dumpcstate(int st, struct cnfa *cnfa, FILE *f);
 #endif
 /* === regc_cvec.c === */
 static struct cvec *newcvec(int nchrs, int nranges);