users/hanada/postgres.git
14 years agoFix postgresql_fdw to not remove quals from PlanState.qual even if pgsql_fdw
Shigeru Hanada [Fri, 3 Dec 2010 07:58:59 +0000 (16:58 +0900)]
Fix postgresql_fdw to not remove quals from PlanState.qual even if
some of quals are evaluated on remote side.  All quals are evaluated
in core executor anytime.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Fri, 3 Dec 2010 07:46:02 +0000 (16:46 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoMerge branch 'master' into fdw_core fdw_core
Shigeru Hanada [Fri, 3 Dec 2010 07:45:58 +0000 (16:45 +0900)]
Merge branch 'master' into fdw_core

14 years agoRemove unnecessary string null-termination in pg_convert.
Itagaki Takahiro [Fri, 3 Dec 2010 03:00:27 +0000 (12:00 +0900)]
Remove unnecessary string null-termination in pg_convert.
We can directly verify the unterminated input with pg_verify_mbstr_len.

14 years agoCreate core infrastructure for KNNGIST.
Tom Lane [Fri, 3 Dec 2010 01:50:48 +0000 (20:50 -0500)]
Create core infrastructure for KNNGIST.

This is a heavily revised version of builtin_knngist_core-0.9.  The
ordering operators are no longer mixed in with actual quals, which would
have confused not only humans but significant parts of the planner.
Instead, ordering operators are carried separately throughout planning and
execution.

Since the API for ambeginscan and amrescan functions had to be changed
anyway, this commit takes the opportunity to rationalize that a bit.
RelationGetIndexScan no longer forces a premature index_rescan call;
instead, callers of index_beginscan must call index_rescan too.  Aside from
making the AM-side initialization logic a bit less peculiar, this has the
advantage that we do not make a useless extra am_rescan call when there are
runtime key values.  AMs formerly could not assume that the key values
passed to amrescan were actually valid; now they can.

Teodor Sigaev and Tom Lane

14 years agoMove private struct declaration to compress_io.c
Alvaro Herrera [Thu, 2 Dec 2010 20:38:49 +0000 (17:38 -0300)]
Move private struct declaration to compress_io.c

Keep only the typedef in the header file.

14 years agoRemove trailing whitespace
Alvaro Herrera [Thu, 2 Dec 2010 20:38:31 +0000 (17:38 -0300)]
Remove trailing whitespace

14 years agoRemove useless struct declaration
Alvaro Herrera [Thu, 2 Dec 2010 20:25:18 +0000 (17:25 -0300)]
Remove useless struct declaration

14 years agoSilence compiler
Alvaro Herrera [Thu, 2 Dec 2010 20:21:53 +0000 (17:21 -0300)]
Silence compiler

14 years agoRefactor the pg_dump zlib code from pg_backup_custom.c to a separate file,
Heikki Linnakangas [Thu, 2 Dec 2010 19:39:03 +0000 (21:39 +0200)]
Refactor the pg_dump zlib code from pg_backup_custom.c to a separate file,
to make it easier to reuse that code. There is no user-visible changes.

This is in preparation for the patch to add a new archive format, a directory,
to perform a custom-like dump but with each table being dumped to a separate
file (that in turn is a prerequisite for parallel pg_dump). This also makes it
easier to add new compression methods in the future, and makes the
pg_backup_custom.c code easier to read, when the compression-related code is
factored out.

Joachim Wieland, with heavy editorialization by me.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Wed, 1 Dec 2010 08:45:17 +0000 (17:45 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoMerge branch 'master' into fdw_core
Shigeru Hanada [Wed, 1 Dec 2010 08:45:12 +0000 (17:45 +0900)]
Merge branch 'master' into fdw_core

14 years agoPrevent inlining a SQL function with multiple OUT parameters.
Tom Lane [Wed, 1 Dec 2010 05:53:18 +0000 (00:53 -0500)]
Prevent inlining a SQL function with multiple OUT parameters.

There were corner cases in which the planner would attempt to inline such
a function, which would result in a failure at runtime due to loss of
information about exactly what the result record type is.  Fix by disabling
inlining when the function's recorded result type is RECORD.  There might
be some sub-cases where inlining could still be allowed, but this is a
simple and backpatchable fix, so leave refinements for another day.
Per bug #5777 from Nate Carson.

Back-patch to all supported branches.  8.1 happens to avoid a core-dump
here, but it still does the wrong thing.

14 years agoSimplify and speed up mapping of index opfamilies to pathkeys.
Tom Lane [Mon, 29 Nov 2010 17:29:42 +0000 (12:29 -0500)]
Simplify and speed up mapping of index opfamilies to pathkeys.

Formerly we looked up the operators associated with each index (caching
them in relcache) and then the planner looked up the btree opfamily
containing such operators in order to build the btree-centric pathkey
representation that describes the index's sort order.  This is quite
pointless for btree indexes: we might as well just use the index's opfamily
information directly.  That saves syscache lookup cycles during planning,
and furthermore allows us to eliminate the relcache's caching of operators
altogether, which may help in reducing backend startup time.

I added code to plancat.c to perform the same type of double lookup
on-the-fly if it's ever faced with a non-btree amcanorder index AM.
If such a thing actually becomes interesting for production, we should
replace that logic with some more-direct method for identifying the
corresponding btree opfamily; but it's not worth spending effort on now.

There is considerably more to do pursuant to my recent proposal to get rid
of sort-operator-based representations of sort orderings, but this patch
grabs some of the low-hanging fruit.  I'll look at the remainder of that
work after the current commitfest.

14 years agoBe consistent about writing "[, ...]" instead "[,...]" in the docs.
Heikki Linnakangas [Mon, 29 Nov 2010 09:49:51 +0000 (11:49 +0200)]
Be consistent about writing "[, ...]" instead "[,...]" in the docs.

Christoph Berg.

14 years agoFix typo.
Robert Haas [Mon, 29 Nov 2010 01:46:11 +0000 (20:46 -0500)]
Fix typo.

Fujii Masao

14 years agoMove call to GetTopTransactionId() earlier in LockAcquire(),
Simon Riggs [Mon, 29 Nov 2010 01:08:02 +0000 (01:08 +0000)]
Move call to GetTopTransactionId() earlier in LockAcquire(),
removing an infrequently occurring race condition in Hot Standby.
An xid must be assigned before a lock appears in shared memory,
rather than immediately after, else GetRunningTransactionLocks()
may see InvalidTransactionId, causing assertion failures during
lock processing on standby.

Bug report and diagnosis by Fujii Masao, fix by me.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Mon, 29 Nov 2010 00:54:47 +0000 (09:54 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoMerge branch 'master' into fdw_core
Shigeru Hanada [Mon, 29 Nov 2010 00:54:44 +0000 (09:54 +0900)]
Merge branch 'master' into fdw_core

14 years agoPoint out in default_tablespace's description that CREATE DATABASE ignores it.
Tom Lane [Sat, 27 Nov 2010 21:08:32 +0000 (16:08 -0500)]
Point out in default_tablespace's description that CREATE DATABASE ignores it.

Per gripe from Andreas Scherbaum.

14 years agoIn libpq/Makefile, use OBJS += as a way to break up long link lines into
Bruce Momjian [Sat, 27 Nov 2010 16:02:44 +0000 (11:02 -0500)]
In libpq/Makefile, use OBJS += as a way to break up long link lines into
something that can be documented.

14 years agoNew contrib module, auth_delay.
Robert Haas [Sat, 27 Nov 2010 12:22:25 +0000 (07:22 -0500)]
New contrib module, auth_delay.

KaiGai Kohei, with a few changes by me.

14 years agoA bit more wordsmithing on the PQping documentation.
Tom Lane [Sat, 27 Nov 2010 07:42:22 +0000 (02:42 -0500)]
A bit more wordsmithing on the PQping documentation.

14 years agoOn further testing, PQping also needs an explicit check for AUTH_REQ.
Tom Lane [Sat, 27 Nov 2010 07:11:45 +0000 (02:11 -0500)]
On further testing, PQping also needs an explicit check for AUTH_REQ.

The pg_fe_sendauth code might fail if it can't handle the authentication
request message type --- if so, ping should still say the server is up.

14 years agoRewrite PQping to be more like what we agreed to last week.
Tom Lane [Sat, 27 Nov 2010 06:30:34 +0000 (01:30 -0500)]
Rewrite PQping to be more like what we agreed to last week.

Basically, we want to distinguish all cases where the connection was
not made from those where it was.  A convenient proxy for this is to
see if we got a message with a SQLSTATE code back from the postmaster.
This presumes that the postmaster will always send us a SQLSTATE in
a failure message, which is true for 7.4 and later postmasters in
every case except fork failure.  (We could possibly complicate the
postmaster code to do something about that, but it seems not worth
the trouble, especially since pg_ctl's response for that case should
be to keep waiting anyway.)

If we did get a SQLSTATE from the postmaster, there are basically only
two cases, as per last week's discussion: ERRCODE_CANNOT_CONNECT_NOW
and everything else.  Any other error code implies that the postmaster
is in principle willing to accept connections, it just didn't like or
couldn't handle this particular request.  We want to make a special
case for ERRCODE_CANNOT_CONNECT_NOW so that "pg_ctl start -w" knows
it should keep waiting.

In passing, pick names for the enum constants that are a tad less
likely to present collision hazards in future.

14 years agoClean up IPv4 vs IPv6 bogosity in connectFailureMessage().
Tom Lane [Sat, 27 Nov 2010 00:16:39 +0000 (19:16 -0500)]
Clean up IPv4 vs IPv6 bogosity in connectFailureMessage().

Newly added code was supposing that "struct sockaddr_in" applies to IPv6.

14 years agoFix portability issues in new src/port/inet_net_ntop.c file.
Tom Lane [Fri, 26 Nov 2010 22:59:10 +0000 (17:59 -0500)]
Fix portability issues in new src/port/inet_net_ntop.c file.

1. Don't #include postgres.h in a frontend build.

2. Don't assume that the backend's symbol PGSQL_AF_INET6 has anything to do
with the constant that will be used by system library functions (because,
in point of fact, it usually doesn't).  Fortunately, PGSQL_AF_INET is equal
to AF_INET, so we can just cater for both sets of values in one case
construct without fear of conflict.

14 years agoAdd more ALTER <object> .. SET SCHEMA commands.
Robert Haas [Fri, 26 Nov 2010 22:27:23 +0000 (17:27 -0500)]
Add more ALTER <object> .. SET SCHEMA commands.

This adds support for changing the schema of a conversion, operator,
operator class, operator family, text search configuration, text search
dictionary, text search parser, or text search template.

Dimitri Fontaine, with assorted corrections and other kibitzing.

14 years agoRemove bogus use of PGDLLIMPORT.
Tom Lane [Fri, 26 Nov 2010 22:05:29 +0000 (17:05 -0500)]
Remove bogus use of PGDLLIMPORT.

That macro should be attached to extern declarations, not actual
definitions of variables.

14 years agoFix significant memory leak in contrib/xml2 functions.
Tom Lane [Fri, 26 Nov 2010 20:20:51 +0000 (15:20 -0500)]
Fix significant memory leak in contrib/xml2 functions.

Most of the functions that execute XPath queries leaked the data structures
created by libxml2.  This memory would not be recovered until end of
session, so it mounts up pretty quickly in any serious use of the feature.
Per report from Pavel Stehule, though this isn't his patch.

Back-patch to all supported branches.

14 years agoAdd inet_net_ntop.c as needed by MSVC, per Magnus.
Bruce Momjian [Fri, 26 Nov 2010 19:39:13 +0000 (14:39 -0500)]
Add inet_net_ntop.c as needed by MSVC, per Magnus.

14 years agoUse conn->raddr consistently for non-connect libpq error reporting.
Bruce Momjian [Fri, 26 Nov 2010 18:26:13 +0000 (13:26 -0500)]
Use conn->raddr consistently for non-connect libpq error reporting.

14 years agoUpdate comment that says we only report last libpq connection failure,
Bruce Momjian [Fri, 26 Nov 2010 16:52:03 +0000 (11:52 -0500)]
Update comment that says we only report last libpq connection failure,
per Peter.

14 years agoUse only addr_cur when reporting connection failures in libpq.
Bruce Momjian [Fri, 26 Nov 2010 16:49:35 +0000 (11:49 -0500)]
Use only addr_cur when reporting connection failures in libpq.

14 years agoAbandon use of Makefile variables in libpq/Makefile because MSVC scrapes
Bruce Momjian [Fri, 26 Nov 2010 16:10:26 +0000 (11:10 -0500)]
Abandon use of Makefile variables in libpq/Makefile because MSVC scrapes
the OBJS lines from that file.

Cleanup where possible.

14 years agoIn libpq/Makefile, merge PERM_PGPORT and OPT_PGPORT into a single
Bruce Momjian [Fri, 26 Nov 2010 15:22:09 +0000 (10:22 -0500)]
In libpq/Makefile, merge PERM_PGPORT and OPT_PGPORT into a single
Makefile variable PGPORT, for clarity.

14 years agoImprove pg_ctl "cannot connect" spacing, per Tom, and wording.
Bruce Momjian [Fri, 26 Nov 2010 15:04:18 +0000 (10:04 -0500)]
Improve pg_ctl "cannot connect" spacing, per Tom, and wording.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Fri, 26 Nov 2010 05:31:34 +0000 (14:31 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoMerge branch 'master' into fdw_core
Shigeru Hanada [Fri, 26 Nov 2010 05:31:13 +0000 (14:31 +0900)]
Merge branch 'master' into fdw_core

14 years agoImprove pg_ctl "cannot connect" warning, per suggestion from Magnus.
Bruce Momjian [Thu, 25 Nov 2010 19:38:20 +0000 (14:38 -0500)]
Improve pg_ctl "cannot connect" warning, per suggestion from Magnus.

14 years agoFor libpq/Makefile OPT_PGPORT, remove .o extension after we test
Bruce Momjian [Thu, 25 Nov 2010 18:19:31 +0000 (13:19 -0500)]
For libpq/Makefile OPT_PGPORT, remove .o extension after we test
configure's LIBOBJS.  Should fix buildfarm failures.

14 years agoAdd PQping and PQpingParams to libpq to allow detection of the server's
Bruce Momjian [Thu, 25 Nov 2010 18:09:38 +0000 (13:09 -0500)]
Add PQping and PQpingParams to libpq to allow detection of the server's
status, including a status where the server is running but refuses a
postgres connection.

Have pg_ctl use this new function.  This fixes the case where pg_ctl
reports that the server is not running (cannot connect) but in fact it
is running.

14 years agoFix getaddrinfo() in pgport to use proper parameters, as detected by
Bruce Momjian [Thu, 25 Nov 2010 17:56:59 +0000 (12:56 -0500)]
Fix getaddrinfo() in pgport to use proper parameters, as detected by
Win32 buildfarm members.

14 years agoRestructure how libpq includes external C files, for clarity.
Bruce Momjian [Thu, 25 Nov 2010 17:51:06 +0000 (12:51 -0500)]
Restructure how libpq includes external C files, for clarity.

14 years agoObject access hook framework, with post-creation hook.
Robert Haas [Thu, 25 Nov 2010 16:48:49 +0000 (11:48 -0500)]
Object access hook framework, with post-creation hook.

After a SQL object is created, we provide an opportunity for security
or logging plugins to get control; for example, a security label provider
could use this to assign an initial security label to newly created
objects.  The basic infrastructure is (hopefully) reusable for other types
of events that might require similar treatment.

KaiGai Kohei, with minor adjustments.

14 years agoDon't raise "identifier will be truncated" messages in dblink
Itagaki Takahiro [Thu, 25 Nov 2010 10:40:58 +0000 (19:40 +0900)]
Don't raise "identifier will be truncated" messages in dblink
except creating new connections.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Thu, 25 Nov 2010 06:38:43 +0000 (15:38 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoFix pg_dump to omit whole of OPTIONS clause when the foreign table
Shigeru Hanada [Thu, 25 Nov 2010 06:35:23 +0000 (15:35 +0900)]
Fix pg_dump to omit whole of OPTIONS clause when the foreign table
has no generic option.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Thu, 25 Nov 2010 05:33:45 +0000 (14:33 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoMerge branch 'master' into fdw_core
Shigeru Hanada [Thu, 25 Nov 2010 05:31:15 +0000 (14:31 +0900)]
Merge branch 'master' into fdw_core

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Thu, 25 Nov 2010 05:28:46 +0000 (14:28 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoFix indent.
Shigeru Hanada [Thu, 25 Nov 2010 05:28:34 +0000 (14:28 +0900)]
Fix indent.

14 years agoAdd inet_net_ntop.c to .gitignore.
Robert Haas [Thu, 25 Nov 2010 05:12:25 +0000 (00:12 -0500)]
Add inet_net_ntop.c to .gitignore.

14 years agoRemove belt-and-suspenders guards against buffer pin leaks.
Robert Haas [Thu, 25 Nov 2010 05:06:46 +0000 (00:06 -0500)]
Remove belt-and-suspenders guards against buffer pin leaks.

Forcibly releasing all leftover buffer pins should be unnecessary now
that we have a robust ResourceOwner mechanism, and it significantly
increases the cost of process shutdown.  Instead, in an assert-enabled
build, assert that no pins are held; in a non-assert-enabled build, do
nothing.

14 years agoRemove oid support on foreign tables.
Shigeru Hanada [Thu, 25 Nov 2010 04:34:14 +0000 (13:34 +0900)]
Remove oid support on foreign tables.

14 years agoMerge branch 'fdw_core' into pgsql_fdw
Shigeru Hanada [Thu, 25 Nov 2010 04:17:34 +0000 (13:17 +0900)]
Merge branch 'fdw_core' into pgsql_fdw

14 years agoRevert unnecessary changes.
Shigeru Hanada [Thu, 25 Nov 2010 04:14:49 +0000 (13:14 +0900)]
Revert unnecessary changes.

14 years agoMerge branch 'master' into fdw_core
Shigeru Hanada [Thu, 25 Nov 2010 03:53:51 +0000 (12:53 +0900)]
Merge branch 'master' into fdw_core

Conflicts:
src/backend/commands/tablecmds.c

14 years agoProperly add new inet_net_ntop file to libpq Makefile.
Bruce Momjian [Thu, 25 Nov 2010 02:58:47 +0000 (21:58 -0500)]
Properly add new inet_net_ntop file to libpq Makefile.

14 years agoRemove oid support on foreign tables.
Shigeru Hanada [Thu, 25 Nov 2010 02:30:55 +0000 (11:30 +0900)]
Remove oid support on foreign tables.

14 years agoDocument that a CHECKPOINT before taking a file system snapshot can
Bruce Momjian [Wed, 24 Nov 2010 23:41:28 +0000 (18:41 -0500)]
Document that a CHECKPOINT before taking a file system snapshot can
reduce recovery time.

14 years agoWhen reporting the server as not responding, if the hostname was
Bruce Momjian [Wed, 24 Nov 2010 22:04:19 +0000 (17:04 -0500)]
When reporting the server as not responding, if the hostname was
supplied, also print the IP address.  This allows IPv4 and IPv6 failures
to be distinguished.  Also useful when a hostname resolves to multiple
IP addresses.

Also, remove use of inet_ntoa() and use our own inet_net_ntop() in all
places, including in libpq, because it is thread-safe.

14 years agoCreate the system catalog infrastructure needed for KNNGIST.
Tom Lane [Wed, 24 Nov 2010 19:20:39 +0000 (14:20 -0500)]
Create the system catalog infrastructure needed for KNNGIST.

This commit adds columns amoppurpose and amopsortfamily to pg_amop, and
column amcanorderbyop to pg_am.  For the moment all the entries in
amcanorderbyop are "false", since the underlying support isn't there yet.

Also, extend the CREATE OPERATOR CLASS/ALTER OPERATOR FAMILY commands with
[ FOR SEARCH | FOR ORDER BY sort_operator_family ] clauses to allow the new
columns of pg_amop to be populated, and create pg_dump support for dumping
that information.

I also added some documentation, although it's perhaps a bit premature
given that the feature doesn't do anything useful yet.

Teodor Sigaev, Robert Haas, Tom Lane

14 years agoAdd index entries for more functions
Peter Eisentraut [Tue, 23 Nov 2010 22:00:34 +0000 (00:00 +0200)]
Add index entries for more functions

Also, move index entries into the tables, closer to the function description,
for easier editing in the future.  Resort some tables to be more alphabetical.
Remove the entries for count, max, min, and sum in the tutorial area, because
that was felt to be confusing.

Thom Brown

14 years agoPropagate ALTER TYPE operations to typed tables
Peter Eisentraut [Tue, 23 Nov 2010 20:50:17 +0000 (22:50 +0200)]
Propagate ALTER TYPE operations to typed tables

This adds RESTRICT/CASCADE flags to ALTER TYPE ... ADD/DROP/ALTER/
RENAME ATTRIBUTE to control whether to alter typed tables as well.

14 years agoRemove useless whitespace at end of lines
Peter Eisentraut [Tue, 23 Nov 2010 20:27:50 +0000 (22:27 +0200)]
Remove useless whitespace at end of lines

14 years agoAdd postgresql_fdw as contrib module.
Shigeru Hanada [Tue, 23 Nov 2010 08:09:47 +0000 (17:09 +0900)]
Add postgresql_fdw as contrib module.

14 years agoRemove data file for regression test of file_fdw (moved to contrib).
Shigeru Hanada [Tue, 23 Nov 2010 08:00:30 +0000 (17:00 +0900)]
Remove data file for regression test of file_fdw (moved to contrib).

14 years agoRemove file_fdw.
Shigeru Hanada [Tue, 23 Nov 2010 06:42:02 +0000 (15:42 +0900)]
Remove file_fdw.

Also defer check of handler until the actual scan of foreign table.

14 years agoRemove postgresql_fdw.
Shigeru Hanada [Tue, 23 Nov 2010 05:40:19 +0000 (14:40 +0900)]
Remove postgresql_fdw.

14 years agoMerge branch 'master' into fdw_select_simple
Shigeru Hanada [Tue, 23 Nov 2010 05:46:46 +0000 (14:46 +0900)]
Merge branch 'master' into fdw_select_simple

14 years agoRevert unnecessary chenges to make patch smaller.
Shigeru Hanada [Tue, 23 Nov 2010 05:46:30 +0000 (14:46 +0900)]
Revert unnecessary chenges to make patch smaller.

14 years agoCentralize some ALTER <whatever> .. SET SCHEMA checks.
Robert Haas [Tue, 23 Nov 2010 00:46:15 +0000 (19:46 -0500)]
Centralize some ALTER <whatever> .. SET SCHEMA checks.

Any flavor of ALTER <whatever> .. SET SCHEMA fails if (1) the object
is already in the new schema, (2) either the old or new schema is
a temp schema, or (3) either the old or new schema is the TOAST schema.

Extraced from a patch by Dimitri Fontaine, with additional hacking by me.

14 years agoRemove GucContext parameter from ParseConfigFile
Alvaro Herrera [Mon, 22 Nov 2010 22:00:31 +0000 (19:00 -0300)]
Remove GucContext parameter from ParseConfigFile

14 years agoPut back accidentally-deleted quote_literal() regression tests.
Robert Haas [Mon, 22 Nov 2010 01:46:54 +0000 (20:46 -0500)]
Put back accidentally-deleted quote_literal() regression tests.

14 years agoMerge branch 'master' into fdw_select_simple
Shigeru Hanada [Mon, 22 Nov 2010 00:29:53 +0000 (09:29 +0900)]
Merge branch 'master' into fdw_select_simple

14 years agoBump catversion. Should have done this as part of format(text) patch.
Robert Haas [Sun, 21 Nov 2010 11:34:42 +0000 (06:34 -0500)]
Bump catversion.  Should have done this as part of format(text) patch.

14 years agoAdd new SQL function, format(text).
Robert Haas [Sat, 20 Nov 2010 05:21:17 +0000 (00:21 -0500)]
Add new SQL function, format(text).

Currently, three conversion format specifiers are supported: %s for a
string, %L for an SQL literal, and %I for an SQL identifier.  The latter
two are deliberately designed not to overlap with what sprintf() already
supports, in case we want to add more of sprintf()'s functionality here
later.

Patch by Pavel Stehule, heavily revised by me.  Reviewed by Jeff Janes
and, in earlier versions, by Itagaki Takahiro and Tom Lane.

14 years agoFurther cleanup of indxpath logic related to IndexOptInfo.opfamily array.
Tom Lane [Sat, 20 Nov 2010 20:07:16 +0000 (15:07 -0500)]
Further cleanup of indxpath logic related to IndexOptInfo.opfamily array.

We no longer need the terminating zero entry in opfamily[], so get rid of
it.  Also replace assorted ad-hoc looping logic with simple for and foreach
constructs.  This code is now noticeably more readable than it was an hour
ago; credit to Robert for seeing that it could be simplified.

14 years agoMinor cleanup of indxpath.c.
Robert Haas [Sat, 20 Nov 2010 18:57:27 +0000 (13:57 -0500)]
Minor cleanup of indxpath.c.

Eliminate some superfluous notational complexity around
match_clause_to_indexcol(), and rip out the DoneMatchingIndexKeys
crock.

14 years agoAssorted further cleanup for integer-conversion patch.
Tom Lane [Sat, 20 Nov 2010 17:09:36 +0000 (12:09 -0500)]
Assorted further cleanup for integer-conversion patch.

Avoid depending on LL notation, which is likely to not work in pre-C99
compilers; don't pointlessly use INT32_MIN/INT64_MIN in code that has
the numerical value hard-wired into it anyway; remove some gratuitous
style inconsistencies between pg_ltoa and pg_lltoa; fix int2 test case
so it actually tests int2.

14 years agoExpose quote_literal_cstr() from core.
Robert Haas [Sat, 20 Nov 2010 15:04:48 +0000 (10:04 -0500)]
Expose quote_literal_cstr() from core.

This eliminates the need for inefficient implementions of this
functionality in both contrib/dblink and contrib/tablefunc, so remove
them.  The upcoming patch implementing an in-core format() function
will also require this functionality.

In passing, add some regression tests.

14 years agoUpdate int8-exp-three-digits.out to match new contents of int8.out.
Robert Haas [Sat, 20 Nov 2010 12:06:52 +0000 (07:06 -0500)]
Update int8-exp-three-digits.out to match new contents of int8.out.

14 years agoAttempt to fix breakage caused by signed integer conversion patch.
Robert Haas [Sat, 20 Nov 2010 06:07:04 +0000 (01:07 -0500)]
Attempt to fix breakage caused by signed integer conversion patch.

Use INT_MIN rather than INT32_MIN as we do elsewhere in the code, and
try to work around nonexistence of INT64_MIN if necessary.  Adjust the
new regression tests to something hopefully saner, per observation by
Tom Lane.

14 years agoFix leakage of cost_limit when multiple autovacuum workers are active.
Tom Lane [Sat, 20 Nov 2010 03:28:20 +0000 (22:28 -0500)]
Fix leakage of cost_limit when multiple autovacuum workers are active.

When using default autovacuum_vac_cost_limit, autovac_balance_cost relied
on VacuumCostLimit to contain the correct global value ... but after the
first time through in a particular worker process, it didn't, because we'd
trashed it in previous iterations.  Depending on the state of other autovac
workers, this could result in a steady reduction of the effective
cost_limit setting as a particular worker processed more and more tables,
causing it to go slower and slower.  Spotted by Simon Poole (bug #5759).
Fix by saving and restoring the GUC variables in the loop in do_autovacuum.

In passing, improve a few comments.

Back-patch to 8.3 ... the cost rebalancing code has been buggy since it was
put in.

14 years agoSpeed up conversion of signed integers to C strings.
Robert Haas [Sat, 20 Nov 2010 03:13:11 +0000 (22:13 -0500)]
Speed up conversion of signed integers to C strings.

A hand-coded implementation turns out to be much faster than calling
printf().  In passing, add a few more regresion tests.

Andres Freund, with assorted, mostly cosmetic changes.

14 years agoImprove relation width estimation for subqueries.
Tom Lane [Fri, 19 Nov 2010 22:31:50 +0000 (17:31 -0500)]
Improve relation width estimation for subqueries.

As per the ancient comment for set_rel_width, it really wasn't much good
for relations that aren't plain tables: it would never find any stats and
would always fall back on datatype-based estimates, which are often pretty
silly.  Fix that by copying up width estimates from the subquery planning
process.

At some point we might want to do this for CTEs too, but that would be a
significantly more invasive patch because the sub-PlannerInfo is no longer
accessible by the time it's needed.  I refrained from doing anything about
that, partly for fear of breaking the unmerged CTE-related patches.

In passing, also generate less bogus width estimates for whole-row Vars.

Per a gripe from Jon Nelson.

14 years agoRefactor name of public functions defined for file_fdw to have
Shigeru Hanada [Fri, 19 Nov 2010 14:13:34 +0000 (23:13 +0900)]
Refactor name of public functions defined for file_fdw to have
common prefix "FileState".

14 years agoReplaced custom is_immutable_func() with contain_mutable_functions().
Shigeru Hanada [Fri, 19 Nov 2010 12:31:35 +0000 (21:31 +0900)]
Replaced custom is_immutable_func() with contain_mutable_functions().

14 years agoCreate FOREIGN DATA WRAPPER postgresql_fdw during installation of
Shigeru Hanada [Fri, 19 Nov 2010 12:25:10 +0000 (21:25 +0900)]
Create FOREIGN DATA WRAPPER postgresql_fdw during installation of
postgresql_fdw contrib module.

14 years agoMerge source files for postgresql_fdw into postgresql_fdw.c and
Shigeru Hanada [Fri, 19 Nov 2010 11:07:33 +0000 (20:07 +0900)]
Merge source files for postgresql_fdw into postgresql_fdw.c and
make all functions static.

14 years agoFix postgresql_fdw to support oid system column.
Shigeru Hanada [Thu, 18 Nov 2010 11:33:39 +0000 (20:33 +0900)]
Fix postgresql_fdw to support oid system column.

14 years agoFix bug caused by the wrong usage of appendStringInfo().
Shigeru Hanada [Fri, 19 Nov 2010 01:35:49 +0000 (10:35 +0900)]
Fix bug caused by the wrong usage of appendStringInfo().

14 years agoApply forgotten fix...
Shigeru Hanada [Fri, 19 Nov 2010 01:12:57 +0000 (10:12 +0900)]
Apply forgotten fix...

14 years agoMerge branch 'master' into fdw_select_simple
Shigeru Hanada [Fri, 19 Nov 2010 00:50:45 +0000 (09:50 +0900)]
Merge branch 'master' into fdw_select_simple

14 years agoFix postgresql_fdw to not use prefix in deparsed SQL except table
Shigeru Hanada [Fri, 19 Nov 2010 00:45:42 +0000 (09:45 +0900)]
Fix postgresql_fdw to not use prefix in deparsed SQL except table
reference in FROM clause.

This fix avoids errors which occurs on child table scan with qual.

14 years agoFix file_fdw to treat oid system attribute correctly.
Shigeru Hanada [Thu, 18 Nov 2010 12:53:49 +0000 (21:53 +0900)]
Fix file_fdw to treat oid system attribute correctly.

Regression tests are also revised.

14 years agoImprove plpgsql's error reporting for no-such-column cases.
Tom Lane [Thu, 18 Nov 2010 22:06:57 +0000 (17:06 -0500)]
Improve plpgsql's error reporting for no-such-column cases.

Given a column reference foo.bar, where there is a composite plpgsql
variable foo but it doesn't contain a column bar, the pre-9.0 coding would
immediately throw a "record foo has no field bar" error.  In 9.0 the parser
hook instead falls through to let the core parser see if it can resolve the
reference.  If not, you get a complaint about "missing FROM-clause entry
for table foo", which while in some sense correct isn't terribly helpful.
Complicate things a bit so that we can throw the old error message if
neither the core parser nor the hook are able to resolve the column
reference, while not changing the behavior in any other case.
Per bug #5757 from Andrey Galkin.

14 years agoAdd pg_describe_object function
Alvaro Herrera [Thu, 18 Nov 2010 19:33:48 +0000 (16:33 -0300)]
Add pg_describe_object function

This function is useful to obtain textual descriptions of objects as
stored in pg_depend.

14 years agoDept of second thoughts: don't try to push LIMIT below a SRF.
Tom Lane [Thu, 18 Nov 2010 16:53:49 +0000 (11:53 -0500)]
Dept of second thoughts: don't try to push LIMIT below a SRF.

If we have Limit->Result->Sort, the Result might be projecting a tlist
that contains a set-returning function.  If so, it's possible for the
SRF to sometimes return zero rows, which means we could need to fetch
more than N rows from the Sort in order to satisfy LIMIT N.
So top-N sorting cannot be used in this scenario.