From 14793f47192b5eb02197cd03afb88559d7514b76 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Mon, 27 Jan 2025 08:00:03 +0900 Subject: [PATCH] pg_amcheck: Fix test failure on Windows with non-existing role MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit For SSPI auth extra users need to be explicitly allowed, or we get "SSPI authentication failed" instead of the expected "role does not exist" error. This report also means that the test has never worked on Windows since its introduction in 9706092839db, because it has always bumped on an authentication failure rather than an error about the role not existing. Oversight in eef4a33f62f7, that has added a pattern check on the error generated by the command. Per report from Tom Lane, via buildfarm member drongo. Author: Dagfinn Ilmari Mannsåker Reviewed-by: Andrew Dunstan Discussion: https://postgr.es/m/379085.1737734611@sss.pgh.pa.us --- src/bin/pg_amcheck/t/002_nonesuch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_amcheck/t/002_nonesuch.pl b/src/bin/pg_amcheck/t/002_nonesuch.pl index 2697f1c1b1a..f23368abeab 100644 --- a/src/bin/pg_amcheck/t/002_nonesuch.pl +++ b/src/bin/pg_amcheck/t/002_nonesuch.pl @@ -11,7 +11,7 @@ use Test::More; # Test set-up my ($node, $port); $node = PostgreSQL::Test::Cluster->new('test'); -$node->init; +$node->init(auth_extra => [ '--create-role' => 'no_such_user' ]); $node->start; $port = $node->port; -- 2.30.2