From 45e7e8ca9e9382e8f5e51fe0c085ea7f5d408ac8 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Wed, 30 Apr 2025 23:00:47 +0200 Subject: [PATCH] Convert strncpy to strlcpy We try to avoid using strncpy() due to the ease of which it can be misused. Convert this callsite to use strlcpy() instead to match similar codepaths in this file. Suggested-by: Peter Eisentraut Discussion: https://postgr.es/m/2a796830-de2d-4030-b480-d673f6cc5d94@eisentraut.org --- src/backend/utils/mmgr/mcxt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/backend/utils/mmgr/mcxt.c b/src/backend/utils/mmgr/mcxt.c index 69884701fb4..7d28ca706eb 100644 --- a/src/backend/utils/mmgr/mcxt.c +++ b/src/backend/utils/mmgr/mcxt.c @@ -1664,8 +1664,7 @@ ProcessGetMemoryContextInterrupt(void) num_individual_stats = context_id + 1; meminfo[max_stats - 1].name = dsa_allocate(MemoryStatsDsaArea, namelen + 1); nameptr = dsa_get_address(MemoryStatsDsaArea, meminfo[max_stats - 1].name); - strncpy(nameptr, "Remaining Totals", namelen); - nameptr[namelen] = '\0'; + strlcpy(nameptr, "Remaining Totals", namelen + 1); meminfo[max_stats - 1].ident = InvalidDsaPointer; meminfo[max_stats - 1].path = InvalidDsaPointer; meminfo[max_stats - 1].type = 0; -- 2.30.2