From 5ee7bd944ee812e988a7dee52613ee1c80c13579 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Sun, 20 Apr 2025 08:15:39 +0900 Subject: [PATCH] psql: Fix incorrect status code returned by \getresults When an invalid number of results is requested for \getresults, the status code returned by exec_command_getresults() was PSQL_CMD_SKIP_LINE and not PSQL_CMD_ERROR. This led to incorrect behaviors, with ON_ERROR_STOP for example. Reported-by: Noah Misch Discussion: https://postgr.es/m/20250415213450.1f.nmisch@google.com --- src/bin/psql/command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c index a8a13c2b88b..81a5ba844ba 100644 --- a/src/bin/psql/command.c +++ b/src/bin/psql/command.c @@ -1922,7 +1922,7 @@ exec_command_getresults(PsqlScanState scan_state, bool active_branch) if (num_results < 0) { pg_log_error("\\getresults: invalid number of requested results"); - return PSQL_CMD_SKIP_LINE; + return PSQL_CMD_ERROR; } pset.requested_results = num_results; } -- 2.30.2