From baa1ae04299f9e80ee8610a6bd84b9111f4ed615 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Thu, 31 Oct 2024 08:28:20 +0900 Subject: [PATCH] injection_points: Improve comment about disabled isolation permutation 9f00edc22888 has disabled a permutation due to failures in the CI for FreeBSD environments, but this is a matter of timing. Let's document properly why this type of permutation is a bad idea if relying on a wait done in a SQL function, so as this can be avoided when implementing new tests (this spec is also a template). Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/ZyCa2qsopKaw3W3K@paquier.xyz --- src/test/modules/injection_points/specs/basic.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/modules/injection_points/specs/basic.spec b/src/test/modules/injection_points/specs/basic.spec index 7f44e3ddc35..47db676c0c1 100644 --- a/src/test/modules/injection_points/specs/basic.spec +++ b/src/test/modules/injection_points/specs/basic.spec @@ -26,7 +26,10 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); } step detach2 { SELECT injection_points_detach('injection-points-wait'); } # Detach after wait and wakeup. -# This permutation is proving to be unstable on FreeBSD, so disable for now. +# Permutations like the following one commented out should be avoided, as +# the detach may finish before the SQL function doing the wait returns +# its result. It is recommended to use wakeups as the last permutation +# should a wait be done within an SQL function. #permutation wait1 wakeup2 detach2 # Detach before wakeup. s1 waits until wakeup, ignores the detach. -- 2.30.2