From c462b054ba605d23c1ec139fcca3d758ac139026 Mon Sep 17 00:00:00 2001 From: Masahiko Sawada Date: Mon, 17 Mar 2025 21:34:10 -0700 Subject: [PATCH] Fix the test 005_char_signedness. pg_upgrade test 005_char_signedness was leaving files like delete_old_cluster.sh in the source directory for VPATH and meson builds. The fix is to change the directory to tmp_check before running the test. Reported-by: Robert Haas Reviewed-by: Robert Haas Discussion: http://postgr.es/m/CA+TgmoYg5e4oznn0XGoJ3+mceG1qe_JJt34rF2JLwvGS5T1hgQ@mail.gmail.com --- src/bin/pg_upgrade/t/005_char_signedness.pl | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/bin/pg_upgrade/t/005_char_signedness.pl b/src/bin/pg_upgrade/t/005_char_signedness.pl index 0190747758c..17fa0d48b15 100644 --- a/src/bin/pg_upgrade/t/005_char_signedness.pl +++ b/src/bin/pg_upgrade/t/005_char_signedness.pl @@ -45,6 +45,11 @@ command_like( qr/Default char data signedness:\s+unsigned/, 'updated default char signedness is unsigned in control file'); +# In a VPATH build, we'll be started in the source directory, but we want +# to run pg_upgrade in the build directory so that any files generated finish +# in it, like delete_old_cluster.{sh,bat}. +chdir ${PostgreSQL::Test::Utils::tmp_check}; + # Cannot use --set-char-signedness option for upgrading from v18+ command_checks_all( [ -- 2.30.2