From d268d0f7a16e9e3c6de660b73543d875b8187def Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 18 Jul 2022 14:53:02 -0700 Subject: [PATCH] ecpg: use our instead of my in parse.pl to fix perlcritic complaint In db0a272d123 I used open(our $something, ...), which perlcritic doesn't like. It looks like the warning is due to perlcritic knowing about 'my' but not 'our' when checking for bareword file handles. However, it's clearly unnecessary to use "our" here, change it to "my". Via buildfarm member crake and discussion with Tom Lane. Discussion: https://postgr.es/m/20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de --- src/interfaces/ecpg/preproc/parse.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/interfaces/ecpg/preproc/parse.pl b/src/interfaces/ecpg/preproc/parse.pl index a15f563ad45..8fb22242492 100644 --- a/src/interfaces/ecpg/preproc/parse.pl +++ b/src/interfaces/ecpg/preproc/parse.pl @@ -27,8 +27,8 @@ GetOptions( 'parser=s' => \$parser,) or die "wrong arguments"; # open parser / output file early, to raise errors early -open(our $parserfh, '<', $parser) or die "could not open parser file $parser"; -open(our $outfh, '>', $outfile) or die "could not open output file $outfile"; +open(my $parserfh, '<', $parser) or die "could not open parser file $parser"; +open(my $outfh, '>', $outfile) or die "could not open output file $outfile"; my $copymode = 0; my $brace_indent = 0; -- 2.30.2