Skip to content

Commit 443fae4

Browse files
Merge pull request #23 from kamal-kaur04/set-browserstackLocal-true
Set browserstackLocal as true in config
2 parents c8f5629 + 4bf9fb6 commit 443fae4

File tree

5 files changed

+8
-20
lines changed

5 files changed

+8
-20
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
- Install dependencies `mvn compile`
1313
- To run the test suite having cross-platform with parallelization, run `mvn test -P sample-test`
1414
- To run local tests, run `mvn test -P sample-local-test`
15+
- To view Allure Reports, run `allure serve target/allure-results`
1516

1617
Understand how many parallel sessions you need by using our [Parallel Test Calculator](https://www.browserstack.com/automate/parallel-calculator?ref=github)
1718

browserstack.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@ framework: cucumber-testng
3131
platforms:
3232
- os: OS X
3333
osVersion: Big Sur
34-
browser: Chrome
34+
browserName: Chrome
3535
browserVersion: latest
3636
- os: Windows
3737
osVersion: 10
38-
browser: Edge
38+
browserName: Edge
3939
browserVersion: latest
4040
- device: Samsung Galaxy S22 Ultra
4141
browserName: chrome # Try 'samsung' for Samsung browser

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ repositories {
77
}
88

99
dependencies {
10-
implementation 'org.seleniumhq.selenium:selenium-java:3.141.59'
10+
implementation 'org.seleniumhq.selenium:selenium-java:4.1.4'
1111
testImplementation 'io.cucumber:cucumber-java:7.3.4'
1212
testImplementation 'io.cucumber:cucumber-testng:7.3.4'
1313
testImplementation 'io.cucumber:cucumber-core:7.3.4'

pom.xml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<maven.compiler.target>1.8</maven.compiler.target>
1717
<cucumber.version>7.4.1</cucumber.version>
1818
<testng.version>7.4.0</testng.version>
19-
<selenium-java.version>3.141.59</selenium-java.version>
19+
<selenium-java.version>4.1.4</selenium-java.version>
2020
<browserstack-local-java.version>1.0.6</browserstack-local-java.version>
2121
<json-simple.version>1.1.1</json-simple.version>
2222
<browserstack-java-sdk.version>LATEST</browserstack-java-sdk.version>
@@ -47,27 +47,12 @@
4747
<version>${selenium-java.version}</version>
4848
<scope>test</scope>
4949
</dependency>
50-
<dependency>
51-
<groupId>com.browserstack</groupId>
52-
<artifactId>browserstack-local-java</artifactId>
53-
<version>${browserstack-local-java.version}</version>
54-
</dependency>
5550
<dependency>
5651
<groupId>com.browserstack</groupId>
5752
<artifactId>browserstack-java-sdk</artifactId>
5853
<version>${browserstack-java-sdk.version}</version>
5954
<scope>compile</scope>
6055
</dependency>
61-
<dependency>
62-
<groupId>com.googlecode.json-simple</groupId>
63-
<artifactId>json-simple</artifactId>
64-
<version>${json-simple.version}</version>
65-
</dependency>
66-
<dependency>
67-
<groupId>org.apache.commons</groupId>
68-
<artifactId>commons-lang3</artifactId>
69-
<version>3.11</version>
70-
</dependency>
7156
<dependency>
7257
<groupId>io.qameta.allure</groupId>
7358
<artifactId>allure-testng</artifactId>

src/test/java/com/browserstack/pageobjects/HomePage.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
import org.openqa.selenium.support.ui.ExpectedConditions;
66
import org.openqa.selenium.support.ui.WebDriverWait;
77

8+
import java.time.Duration;
9+
810
public class HomePage {
911
private WebDriver webDriver;
1012

@@ -33,7 +35,7 @@ public void clickAddToCartButton() {
3335
}
3436

3537
public void waitForCartToOpen() {
36-
new WebDriverWait(webDriver,30).until(ExpectedConditions.visibilityOfAllElementsLocatedBy(cartPane));
38+
new WebDriverWait(webDriver, Duration.ofSeconds(30)).until(ExpectedConditions.visibilityOfAllElementsLocatedBy(cartPane));
3739
}
3840

3941
public String getProductCartText() {

0 commit comments

Comments
 (0)