Remove quarantine attributes from Blazor e2e tests (#37890)

pranavkm · web-flow · commit 4504ce5f8e2e · 2021-10-28T00:45:13.000Z
Removing quarantine attribute from tests in the aspnetcore-components-e2e pipeline with 100% success rates over the lifetime of the pipeline. This is primarily a cleanup activity as these tests are not run as part of the regular test pipeline and unquarantining does not change the outcome of the build. Fixes #23015 Fixes #31195 Fixes #34886 Fixes #34395 Fixes #33297 Fixes #33528 Fixes #32907 Fixes #34867 Fixes #33530 Fixes #33715 Fixes #34183 Fixes #33454
diff --git a/src/Components/test/E2ETest/ServerExecutionTests/CircuitGracefulTerminationTests.cs b/src/Components/test/E2ETest/ServerExecutionTests/CircuitGracefulTerminationTests.cs
@@ -79,7 +79,6 @@ public async Task ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircui
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23015")]
         public async Task ClosingTheBrowserWindow_GracefullyDisconnects_WhenNavigatingAwayFromThePage()
         {
             // Arrange & Act
diff --git a/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/ServerEventTest.cs
@@ -19,7 +19,6 @@ public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerF
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public override void EventDuringBatchRendering_CanTriggerDOMEvents()
         {
             base.EventDuringBatchRendering_CanTriggerDOMEvents();
diff --git a/src/Components/test/E2ETest/Tests/BinaryHttpClientTest.cs b/src/Components/test/E2ETest/Tests/BinaryHttpClientTest.cs
@@ -46,7 +46,6 @@ protected override void InitializeAsyncCore()
         public override Task InitializeAsync() => base.InitializeAsync(Guid.NewGuid().ToString());
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33454")]
         public void CanSendAndReceiveBytes()
         {
             IssueRequest("/subdir/api/data");
diff --git a/src/Components/test/E2ETest/Tests/BindTest.cs b/src/Components/test/E2ETest/Tests/BindTest.cs
@@ -611,7 +611,6 @@ public void CanBindTextboxNullableDecimal()
         // This tests what happens you put invalid (unconvertable) input in. This is separate from the
         // other tests because it requires type="text" - the other tests use type="number"
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34183")]
         public void CanBindTextbox_Decimal_InvalidInput()
         {
             var target = Browser.Exists(By.Id("textbox-decimal-invalid"));
diff --git a/src/Components/test/E2ETest/Tests/CascadingValueTest.cs b/src/Components/test/E2ETest/Tests/CascadingValueTest.cs
@@ -30,7 +30,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33715")]
         public void CanUpdateValuesMatchedByType()
         {
             var currentCount = Browser.Exists(By.Id("current-count"));
@@ -50,7 +49,6 @@ public void CanUpdateValuesMatchedByType()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33530")]
         public void CanUpdateValuesMatchedByName()
         {
             var currentFlag1Value = Browser.Exists(By.Id("flag-1"));
@@ -72,7 +70,6 @@ public void CanUpdateValuesMatchedByName()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34867")]
         public void CanUpdateFixedValuesMatchedByInterface()
         {
             var currentCount = Browser.Exists(By.Id("current-count"));
diff --git a/src/Components/test/E2ETest/Tests/ComponentRenderingTestBase.cs b/src/Components/test/E2ETest/Tests/ComponentRenderingTestBase.cs
@@ -467,7 +467,6 @@ public void CanUseFocusExtensionToFocusElementPreventScroll()
         }
 
         [Theory]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/32907")]
         [InlineData("focus-button-onafterrender-invoke")]
         [InlineData("focus-button-onafterrender-await")]
         public void CanFocusDuringOnAfterRenderAsyncWithFocusInEvent(string triggerButton)
diff --git a/src/Components/test/E2ETest/Tests/ErrorBoundaryTest.cs b/src/Components/test/E2ETest/Tests/ErrorBoundaryTest.cs
@@ -147,7 +147,6 @@ public async Task CanHandleErrorsAfterDisposingErrorBoundary()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33528")]
         public void CanHandleMultipleAsyncErrorsFromDescendants()
         {
             var container = Browser.Exists(By.Id("multiple-child-errors-test"));
diff --git a/src/Components/test/E2ETest/Tests/EventBubblingTest.cs b/src/Components/test/E2ETest/Tests/EventBubblingTest.cs
@@ -48,7 +48,6 @@ public void BubblingStandardEvent_FiredOnElementWithHandler()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void BubblingStandardEvent_FiredOnElementWithoutHandler()
         {
             Browser.Exists(By.Id("button-without-onclick")).Click();
diff --git a/src/Components/test/E2ETest/Tests/EventTest.cs b/src/Components/test/E2ETest/Tests/EventTest.cs
@@ -203,7 +203,6 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void PreventDefault_DotNotApplyByDefault()
         {
             var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();
@@ -212,7 +211,6 @@ public void PreventDefault_DotNotApplyByDefault()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void InputEvent_RespondsOnKeystrokes()
         {
             Browser.MountTestComponent<InputEventComponent>();
@@ -230,7 +228,6 @@ public void InputEvent_RespondsOnKeystrokes()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()
         {
             // This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked
diff --git a/src/Components/test/E2ETest/Tests/GlobalizationTest.cs b/src/Components/test/E2ETest/Tests/GlobalizationTest.cs
@@ -97,7 +97,6 @@ private static string NormalizeWhitespace(string value)
         [Theory]
         [InlineData("en-US")]
         [InlineData("fr-FR")]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33297")]
         public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields(string culture)
         {
             var cultureInfo = CultureInfo.GetCultureInfo(culture);
diff --git a/src/Components/test/E2ETest/Tests/MultipleHostedAppTest.cs b/src/Components/test/E2ETest/Tests/MultipleHostedAppTest.cs
@@ -31,7 +31,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34395")]
         public void CanLoadBlazorAppFromSubPath()
         {
             Navigate("/app/");
@@ -41,14 +40,12 @@ public void CanLoadBlazorAppFromSubPath()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34395")]
         public void HasTitle()
         {
             Assert.Equal("Sample Blazor app", Browser.Title);
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34395")]
         public void ServesStaticAssetsFromClientAppWebRoot()
         {
             var javascriptExecutor = (IJavaScriptExecutor)Browser;
diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs
@@ -610,12 +610,10 @@ public void ResetsScrollPositionWhenPerformingInternalNavigation_ProgrammaticNav
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void PreventDefault_CanBlockNavigation_ForInternalNavigation_PreventDefaultTarget()
             => PreventDefault_CanBlockNavigation("internal", "target");
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]
         public void PreventDefault_CanBlockNavigation_ForExternalNavigation_PreventDefaultAncestor()
             => PreventDefault_CanBlockNavigation("external", "ancestor");
 
diff --git a/src/Components/test/E2ETest/Tests/WebAssemblyAuthenticationTests.cs b/src/Components/test/E2ETest/Tests/WebAssemblyAuthenticationTests.cs
@@ -67,7 +67,6 @@ protected override void InitializeAsyncCore()
         }
 
         [Fact]
-        [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34886")]
         public void WasmAuthentication_Loads()
         {
             Browser.Equal("Wasm.Authentication.Client", () => Browser.Title);

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,6 @@ public async Task ClosingTheBrowserWindow_GracefullyDisconnects_TheCurrentCircui`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`[Fact]`
`82`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/23015")]`
`83`	`82`	`public async Task ClosingTheBrowserWindow_GracefullyDisconnects_WhenNavigatingAwayFromThePage()`
`84`	`83`	`{`
`85`	`84`	`// Arrange & Act`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ public ServerEventTest(BrowserFixture browserFixture, ToggleExecutionModeServerF`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`[Fact]`
`22`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]`
`23`	`22`	`public override void EventDuringBatchRendering_CanTriggerDOMEvents()`
`24`	`23`	`{`
`25`	`24`	`base.EventDuringBatchRendering_CanTriggerDOMEvents();`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ protected override void InitializeAsyncCore()`
`46`	`46`	`public override Task InitializeAsync() => base.InitializeAsync(Guid.NewGuid().ToString());`
`47`	`47`
`48`	`48`	`[Fact]`
`49`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33454")]`
`50`	`49`	`public void CanSendAndReceiveBytes()`
`51`	`50`	`{`
`52`	`51`	`IssueRequest("/subdir/api/data");`
Original file line number	Diff line number	Diff line change
`@@ -611,7 +611,6 @@ public void CanBindTextboxNullableDecimal()`
`611`	`611`	`// This tests what happens you put invalid (unconvertable) input in. This is separate from the`
`612`	`612`	`// other tests because it requires type="text" - the other tests use type="number"`
`613`	`613`	`[Fact]`
`614`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34183")]`
`615`	`614`	`public void CanBindTextbox_Decimal_InvalidInput()`
`616`	`615`	`{`
`617`	`616`	`var target = Browser.Exists(By.Id("textbox-decimal-invalid"));`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ protected override void InitializeAsyncCore()`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`[Fact]`
`33`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33715")]`
`34`	`33`	`public void CanUpdateValuesMatchedByType()`
`35`	`34`	`{`
`36`	`35`	`var currentCount = Browser.Exists(By.Id("current-count"));`
`@@ -50,7 +49,6 @@ public void CanUpdateValuesMatchedByType()`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`[Fact]`
`53`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33530")]`
`54`	`52`	`public void CanUpdateValuesMatchedByName()`
`55`	`53`	`{`
`56`	`54`	`var currentFlag1Value = Browser.Exists(By.Id("flag-1"));`
`@@ -72,7 +70,6 @@ public void CanUpdateValuesMatchedByName()`
`72`	`70`	`}`
`73`	`71`
`74`	`72`	`[Fact]`
`75`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34867")]`
`76`	`73`	`public void CanUpdateFixedValuesMatchedByInterface()`
`77`	`74`	`{`
`78`	`75`	`var currentCount = Browser.Exists(By.Id("current-count"));`
Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,6 @@ public void CanUseFocusExtensionToFocusElementPreventScroll()`
`467`	`467`	`}`
`468`	`468`
`469`	`469`	`[Theory]`
`470`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/32907")]`
`471`	`470`	`[InlineData("focus-button-onafterrender-invoke")]`
`472`	`471`	`[InlineData("focus-button-onafterrender-await")]`
`473`	`472`	`public void CanFocusDuringOnAfterRenderAsyncWithFocusInEvent(string triggerButton)`
Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,6 @@ public async Task CanHandleErrorsAfterDisposingErrorBoundary()`
`147`	`147`	`}`
`148`	`148`
`149`	`149`	`[Fact]`
`150`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33528")]`
`151`	`150`	`public void CanHandleMultipleAsyncErrorsFromDescendants()`
`152`	`151`	`{`
`153`	`152`	`var container = Browser.Exists(By.Id("multiple-child-errors-test"));`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ public void BubblingStandardEvent_FiredOnElementWithHandler()`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`[Fact]`
`51`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]`
`52`	`51`	`public void BubblingStandardEvent_FiredOnElementWithoutHandler()`
`53`	`52`	`{`
`54`	`53`	`Browser.Exists(By.Id("button-without-onclick")).Click();`
Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,6 @@ public void PreventDefault_AppliesToFormOnSubmitHandlers()`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`[Fact]`
`206`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]`
`207`	`206`	`public void PreventDefault_DotNotApplyByDefault()`
`208`	`207`	`{`
`209`	`208`	`var appElement = Browser.MountTestComponent<EventPreventDefaultComponent>();`
`@@ -212,7 +211,6 @@ public void PreventDefault_DotNotApplyByDefault()`
`212`	`211`	`}`
`213`	`212`
`214`	`213`	`[Fact]`
`215`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]`
`216`	`214`	`public void InputEvent_RespondsOnKeystrokes()`
`217`	`215`	`{`
`218`	`216`	`Browser.MountTestComponent<InputEventComponent>();`
`@@ -230,7 +228,6 @@ public void InputEvent_RespondsOnKeystrokes()`
`230`	`228`	`}`
`231`	`229`
`232`	`230`	`[Fact]`
`233`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31195")]`
`234`	`231`	`public void InputEvent_RespondsOnKeystrokes_EvenIfUpdatesAreLaggy()`
`235`	`232`	`{`
`236`	`233`	`// This test doesn't mean much on WebAssembly - it just shows that even if the CPU is locked`
Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,6 @@ private static string NormalizeWhitespace(string value)`
`97`	`97`	`[Theory]`
`98`	`98`	`[InlineData("en-US")]`
`99`	`99`	`[InlineData("fr-FR")]`
`100`		`- [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/33297")]`
`101`	`100`	`public void CanSetCultureAndParseCultureInvariantNumbersAndDatesWithInputFields(string culture)`
`102`	`101`	`{`
`103`	`102`	`var cultureInfo = CultureInfo.GetCultureInfo(culture);`