Skip to content

Auth crashes from main and worker threads accessing a Set of AuthKeychainServices #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
importRyan opened this issue May 9, 2025 · 1 comment · May be fixed by #14862
Open

Auth crashes from main and worker threads accessing a Set of AuthKeychainServices #14835

importRyan opened this issue May 9, 2025 · 1 comment · May be fixed by #14862
Assignees
@ncooke3
Labels
api: auth
Milestone
11.14.0 - M165

Comments

@importRyan
Copy link

importRyan commented May 9, 2025 •
edited
Loading

Description

We're seeing a few crash paths from concurrent access of a Set private to AuthKeychainServices in the 11.12.0 SDK (and going back several versions). I believe it is this one.

Below are a few traces of variants of that crash, some on com.google.firebase.auth.globalWorkQueue and some on main. All of these crashes occur early, while didFinishLaunchingWithOptions is in scope. There we call Firebase.configure()and then Auth.getStoredUser(forAccessGroup: nil) as part of a local-to-iCloud keychain migration routine.

Traces
onGlobal-1.txt
onGlobal-2.txt
main-1.txt
main-2.txt

Reproducing the issue

No response

Firebase SDK Version

11.12.0

Xcode Version

16.3

Installation Method

Swift Package Manager

Firebase Product(s)

Authentication, Crashlytics, All

Targeted Platforms

iOS

Relevant Log Output



If using Swift Package Manager, the project's Package.resolved




Expand Package.resolved snippet



{
  "originHash" : "36fae030e83cb8526a95be9834168f8c82b08dfcc2148980f2c8c81fd2ed565a",
  "pins" : [
    {
      "identity" : "abseil-cpp-binary",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/abseil-cpp-binary.git",
      "state" : {
        "revision" : "bbe8b69694d7873315fd3a4ad41efe043e1c07c5",
        "version" : "1.2024072200.0"
      }
    },
    {
      "identity" : "app-check",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/app-check.git",
      "state" : {
        "revision" : "61b85103a1aeed8218f17c794687781505fbbef5",
        "version" : "11.2.0"
      }
    },
    {
      "identity" : "firebase-ios-sdk",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/firebase-ios-sdk",
      "state" : {
        "revision" : "fbd463894af94d90eb4d6a4e54080459a8179519",
        "version" : "11.12.0"
      }
    },
    {
      "identity" : "googleappmeasurement",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleAppMeasurement.git",
      "state" : {
        "revision" : "f7460ea630bddf172115c28493ae8b3798d95ce3",
        "version" : "11.12.0"
      }
    },
    {
      "identity" : "googledatatransport",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleDataTransport.git",
      "state" : {
        "revision" : "617af071af9aa1d6a091d59a202910ac482128f9",
        "version" : "10.1.0"
      }
    },
    {
      "identity" : "googleutilities",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/GoogleUtilities.git",
      "state" : {
        "revision" : "53156c7ec267db846e6b64c9f4c4e31ba4cf75eb",
        "version" : "8.0.2"
      }
    },
    {
      "identity" : "grpc-binary",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/grpc-binary.git",
      "state" : {
        "revision" : "cc0001a0cf963aa40501d9c2b181e7fc9fd8ec71",
        "version" : "1.69.0"
      }
    },
    {
      "identity" : "gtm-session-fetcher",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/gtm-session-fetcher.git",
      "state" : {
        "revision" : "a2ab612cb980066ee56d90d60d8462992c07f24b",
        "version" : "3.5.0"
      }
    },
    {
      "identity" : "interop-ios-for-google-sdks",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/interop-ios-for-google-sdks.git",
      "state" : {
        "revision" : "040d087ac2267d2ddd4cca36c757d1c6a05fdbfe",
        "version" : "101.0.0"
      }
    },
    {
      "identity" : "leveldb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/leveldb.git",
      "state" : {
        "revision" : "a0bc79961d7be727d258d33d5a6b2f1023270ba1",
        "version" : "1.22.5"
      }
    },
    {
      "identity" : "nanopb",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/firebase/nanopb.git",
      "state" : {
        "revision" : "b7e1104502eca3a213b46303391ca4d3bc8ddec1",
        "version" : "2.30910.0"
      }
    },
    {
      "identity" : "promises",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/google/promises.git",
      "state" : {
        "revision" : "540318ecedd63d883069ae7f1ed811a2df00b6ac",
        "version" : "2.4.0"
      }
    },
    {
      "identity" : "swift-protobuf",
      "kind" : "remoteSourceControl",
      "location" : "https://github.com/apple/swift-protobuf.git",
      "state" : {
        "revision" : "ebc7251dd5b37f627c93698e4374084d98409633",
        "version" : "1.28.2"
      }
    }
  ],
  "version" : 3
}





      		
    

      
  





        



            
            

              
            

        

      


      
    








      

    



      

  
      



  

  @google-oss-bot





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      



      

  


  

    

  





      


        


  
    

      
          
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

      		
    

  





        


            

            
            

              
            

        

      


      

            
  

    
  
    
    

  

  


    












      

  
            


    


    

    

      
    

    


      

          @ncooke3
ncooke3




              self-assigned this


      May 9, 2025

    

  



    

    

      
    

    


      

          @ncooke3
ncooke3




          added this to the   11.14.0 - M165 milestone


      May 16, 2025

    

  



  

  

    
  


  

      

    @ncooke3
ncooke3



    linked a pull request
    
      May 16, 2025
    

    that will
    close
    this issue





  


  

      
   Open

  







  













  
  

    

      

  





  




  
  

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
      @ncooke3
  
    ncooke3
    

      








      


  


  

    Labels
  



    

      

    api: auth









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      
    
  
    11.14.0 - M165
  





    
      
          


  

    

      
        

          
    

    Development
  




            
  
Successfully merging a pull request may close this issue.





    


  
          
      [Auth] Conform 'AuthKeychainServices' to 'Sendable'

    
      firebase/firebase-ios-sdk
    





      
    

  




      

    

  
      

  

    

      4 participants
    

    

        
          @google-oss-bot 
        
          @ncooke3 
        
          @rizafran 
        
          @importRyan