Skip to content

Commit c06eb5e

Browse files
committed
address code review
1 parent ca293e3 commit c06eb5e

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

firestore/ios/firestore-snippets-cpp/AppDelegate.mm

+7-5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@
1919
#include "firebase/app.h"
2020
#include "firebase/firestore.h"
2121

22+
using firebase::App;
23+
using firebase::firestore::Firestore;
24+
2225
@interface AppDelegate ()
2326

2427
@end
@@ -27,13 +30,12 @@ @implementation AppDelegate
2730

2831
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
2932
[FIRApp configure];
30-
#pragma clang diagnostic push
31-
#pragma clang diagnostic ignored "-Wunused-variable"
3233
// [START get_firestore_instance]
33-
firebase::App::Create();
34-
auto db = firebase::firestore::Firestore::GetInstance();
34+
// Make sure the call to `Create()` happens some time before you call Firestore::GetInstance().
35+
App::Create();
36+
Firestore * db = Firestore::GetInstance();
3537
// [END get_firestore_instance]
36-
#pragma clang diagnostic pop
38+
(void)db; // suppress unused variable warning
3739
return YES;
3840
}
3941

0 commit comments

Comments
 (0)