From 4ae62fc3f30fdb2991ac0aa18b15897e74ff2b61 Mon Sep 17 00:00:00 2001 From: Athira M Date: Wed, 22 Jan 2025 19:10:45 +0530 Subject: [PATCH 1/4] Add comment to highlight the default prod value for minimumFetchIntervalMillis. Issue addressed: https://github.com/firebase/firebase-js-sdk/issues/2841 --- snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js | 1 + 1 file changed, 1 insertion(+) diff --git a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js index 131976c5..f5aee1ec 100644 --- a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js +++ b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js @@ -5,5 +5,6 @@ // 'npm run snippets'. // [START rc_set_minimum_fetch_time_modular] +// The default and recommended production fetch interval for Remote Config is 12 hours. remoteConfig.settings.minimumFetchIntervalMillis = 3600000; // [END rc_set_minimum_fetch_time_modular] \ No newline at end of file From 37563e99fb4b33c740d2c886c55ed03a31e708ed Mon Sep 17 00:00:00 2001 From: Athira M Date: Thu, 23 Jan 2025 09:57:31 +0530 Subject: [PATCH 2/4] Update code snipped with default prod value for minimumFetchIntervalMillis. --- snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js | 1 - 1 file changed, 1 deletion(-) diff --git a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js index f5aee1ec..131976c5 100644 --- a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js +++ b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js @@ -5,6 +5,5 @@ // 'npm run snippets'. // [START rc_set_minimum_fetch_time_modular] -// The default and recommended production fetch interval for Remote Config is 12 hours. remoteConfig.settings.minimumFetchIntervalMillis = 3600000; // [END rc_set_minimum_fetch_time_modular] \ No newline at end of file From 0ff4e7cee2aa9dda6640f49be220cca6140b028d Mon Sep 17 00:00:00 2001 From: Athira M Date: Thu, 23 Jan 2025 09:58:46 +0530 Subject: [PATCH 3/4] Update code snipped with default prod value for minimumFetchIntervalMillis. --- snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js | 1 + 1 file changed, 1 insertion(+) diff --git a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js index 131976c5..f5aee1ec 100644 --- a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js +++ b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js @@ -5,5 +5,6 @@ // 'npm run snippets'. // [START rc_set_minimum_fetch_time_modular] +// The default and recommended production fetch interval for Remote Config is 12 hours. remoteConfig.settings.minimumFetchIntervalMillis = 3600000; // [END rc_set_minimum_fetch_time_modular] \ No newline at end of file From 246ed478a1e122bc5b6bad750d0849aef981c5a1 Mon Sep 17 00:00:00 2001 From: Athira M Date: Thu, 23 Jan 2025 10:10:32 +0530 Subject: [PATCH 4/4] Update code snipped with default prod value for minimumFetchIntervalMillis. --- remoteconfig-next/index.js | 1 + snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/remoteconfig-next/index.js b/remoteconfig-next/index.js index aeeb263a..287f3c99 100644 --- a/remoteconfig-next/index.js +++ b/remoteconfig-next/index.js @@ -14,6 +14,7 @@ function getInstance() { function setMinimumFetchTime() { const remoteConfig = getInstance(); // [START rc_set_minimum_fetch_time] + // The default and recommended production fetch interval for Remote Config is 12 hours remoteConfig.settings.minimumFetchIntervalMillis = 3600000; // [END rc_set_minimum_fetch_time] } diff --git a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js index f5aee1ec..77aa9f45 100644 --- a/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js +++ b/snippets/remoteconfig-next/index/rc_set_minimum_fetch_time.js @@ -5,6 +5,6 @@ // 'npm run snippets'. // [START rc_set_minimum_fetch_time_modular] -// The default and recommended production fetch interval for Remote Config is 12 hours. +// The default and recommended production fetch interval for Remote Config is 12 hours remoteConfig.settings.minimumFetchIntervalMillis = 3600000; // [END rc_set_minimum_fetch_time_modular] \ No newline at end of file