Unclear that tests actually validate their results?

[gregfenton]

snippets-web/firestore/test.solution-counters.js

Line 49 in c5bfca3

describe("firestore-solution-counters", () => {

In the test group that starts at the above line, it isn't clear to me that the results of the tests are actually being tested? What validates that the counters are created? What validates that the incremented value is correct?

[samtstern]

@gregfenton most of the tests here are only to ensure that the code is syntactically valid and doesn't throw immediate exceptions. We don't test that they produce the intended backend result, although if you want to submit a PR to improve any of the tests to be more meaningful we'd be happy to review!

[gregfenton]

My main concern is that this snippet is highlighted in the documentation as the source for the Distributed Counters pattern. But these tests do not show how to use the pattern. So we are left to figure things out on our own?

I'm currently struggling with this: https://github.com/gregfenton/example-firestore-distributed-counter

[samtstern]

@gregfenton totally fair! I'm actually no longer on the Firebase team so cc @morganchen12 and @abeisgoat who may want to take a look here.