From 6be6d167be75e04c9ba0ea43397ca79f5488f3b6 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:25:50 -0500 Subject: [PATCH 01/60] add redirect action --- .github/workflows/verify-redirects.yml | 138 +++++++++++++++++++++++++ 1 file changed, 138 insertions(+) create mode 100644 .github/workflows/verify-redirects.yml diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml new file mode 100644 index 00000000..89dda068 --- /dev/null +++ b/.github/workflows/verify-redirects.yml @@ -0,0 +1,138 @@ +name: Redirector + +on: + pull_request_target: + +jobs: + verify-redirects: + name: Verifying Redirects + runs-on: ubuntu-latest + env: + REDIRECTS_FILE: "source/config/redirects" + permissions: + pull-requests: write + steps: + - name: Check Out Code + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Get Changed Files + id: changed-files + uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c + with: + include_all_old_new_renamed_files: true + + - name: Find Missing Redirects for Renamed Files + id: renamed-files + if: steps.changed-files.outputs.renamed_files_count > 0 + env: + RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} + run: | + echo "renamed files: $RENAMED_FILES" + echo "output: ${{ steps.changed-files.outputs.all_old_new_renamed_files }}" + renamed_redirects=() + for file in $RENAMED_FILES; do + + # only run for .txt files + if [[ ! "$file" == *.txt ]]; then + continue + fi + + # format old and new URLs + old=$(echo "$file" | cut -d',' -f1) + old="${old#source}" + old="${old%.txt}" + new=$(echo "$file" | cut -d',' -f2) + new="${new#source}" + new="${new%.txt}" + + # single quotes = ${var} rendered literally; double quotes = $var interpreted + renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' + + # if redirect not already in file, add to array to add to PR description + if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + renamed_redirects+=("$renamed_redirect") + fi + + done + echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" + + - name: Find Missing Redirects for Deleted Files + id: deleted-files + if: steps.changed-files.outputs.deleted_files_count > 0 + env: + DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} + run: | + deleted_redirects=() + for file in $DELETED_FILES; do + + # only run for .txt files + if [[ ! "$file" == *.txt ]]; then + continue + fi + + # format old URL + old=$(echo "$file" | cut -d',' -f1) + old="${old#source}" + old="${old%.txt}" + + # single quotes = ${var} rendered literally; double quotes = $var interpreted + deleted_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' + + # if redirect not already in file, add to array to add to PR description + if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then + deleted_redirects+=("$deleted_redirect") + fi + + done + echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" + + - name: Build Redirect HTML + id: build-redirect-html + env: + RENAMED_REDIRECTS: ${{ steps.renamed-files.outputs.redirects }} + DELETED_REDIRECTS: ${{ steps.deleted-files.outputs.redirects }} + run: | + # empty string that stays empty if there are no redirects to suggest + redirect_html="" + echo "RENAMED_REDIRECTS: $RENAMED_REDIRECTS" + echo "renamed output: ${{ steps.renamed-files.outputs.redirects }}" + + for renamed_redirect in "${RENAMED_REDIRECTS[@]}"; do + redirect_html+="
  • [<v>-*]: $renamed_redirect
  • " + done + + for deleted_redirect in "${DELETED_REDIRECTS[@]}"; do + redirect_html+="
  • [<v>-*]: $deleted_redirect
  • " + done + + echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" + + - name: Update PR Description + if: steps.build-redirect-html.outputs.redirect_html + uses: MongoCaleb/pr-description-action@4bdfe35b98f64532b419ad20b350a92546cd3aa1 + env: + REDIRECT_HTML: ${{ steps.build-redirect-html.outputs.redirect_html }} + with: + regex: "- \\[ \\] Did you add redirects\\?.*" + appendContentOnMatchOnly: false + regexFlags: is + content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ steps.build-redirect-html.outputs.redirect_html }}\n" + token: ${{ secrets.GITHUB_TOKEN }} + + - name: Check for duplicates in redirects file + run: | + # Specify the file to check + file="$REDIRECTS_FILE" + + if [[ -f "$file" ]]; then + duplicates=$(sort "$file" | uniq -d) + if [[ -n "$duplicates" ]]; then + echo "Duplicate lines found in $file:" + echo "$duplicates" + exit 1 # error + fi + else + echo "File $file does not exist. Skipping duplicate check." + fi From a7d5b5787f0bf54cea1faedb37ebe029bff9fb40 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:32:17 -0500 Subject: [PATCH 02/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 89dda068..26f5be25 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -14,8 +14,6 @@ jobs: steps: - name: Check Out Code uses: actions/checkout@v4 - with: - fetch-depth: 0 - name: Get Changed Files id: changed-files From 53fbac2e1ef9312fc5af45fc0ad2b4839a549055 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:33:25 -0500 Subject: [PATCH 03/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 26f5be25..7858ff96 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -27,8 +27,6 @@ jobs: env: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | - echo "renamed files: $RENAMED_FILES" - echo "output: ${{ steps.changed-files.outputs.all_old_new_renamed_files }}" renamed_redirects=() for file in $RENAMED_FILES; do From 4e123512f3290ce930154ed61b328270b5ea61cb Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:36:01 -0500 Subject: [PATCH 04/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 7858ff96..647c124a 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -47,7 +47,8 @@ jobs: renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + echo "$renamed_redirect was not found" renamed_redirects+=("$renamed_redirect") fi From 3e651e53f2f2c1db889febf36f5b85ab5e5842a3 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:37:13 -0500 Subject: [PATCH 05/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 647c124a..0aed5e77 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -8,7 +8,7 @@ jobs: name: Verifying Redirects runs-on: ubuntu-latest env: - REDIRECTS_FILE: "source/config/redirects" + REDIRECTS_FILE: "config/redirects" permissions: pull-requests: write steps: From d849fc4b6c5386fef54bcc17d2e88bc89ae0b93b Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:42:54 -0500 Subject: [PATCH 06/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 0aed5e77..77554f31 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -47,7 +47,7 @@ jobs: renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + if ! grep -q "${renamed_redirect//\$\\\\$}" $REDIRECTS_FILE; then echo "$renamed_redirect was not found" renamed_redirects+=("$renamed_redirect") fi From be4226074c4a6632950fa3c7433e59c925bccd40 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:48:52 -0500 Subject: [PATCH 07/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 77554f31..45936d59 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -47,7 +47,7 @@ jobs: renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "${renamed_redirect//\$\\\\$}" $REDIRECTS_FILE; then + if ! grep -q "${renamed_redirect//\$\\\$}" $REDIRECTS_FILE; then echo "$renamed_redirect was not found" renamed_redirects+=("$renamed_redirect") fi From d1cf0a5ae184e54b37b2ef290c0e64bdfd7f7f02 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:50:54 -0500 Subject: [PATCH 08/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 45936d59..a50cf54a 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -48,7 +48,9 @@ jobs: # if redirect not already in file, add to array to add to PR description if ! grep -q "${renamed_redirect//\$\\\$}" $REDIRECTS_FILE; then - echo "$renamed_redirect was not found" + echo "Target file: $REDIRECTS_FILE" + echo "Target string: $renamed_redirect" + grep "$renamed_redirect" $REDIRECTS_FILE renamed_redirects+=("$renamed_redirect") fi From 404980c3eebd17b47e06092958befcff0e3c33da Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:53:54 -0500 Subject: [PATCH 09/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index a50cf54a..a7000a1b 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -47,12 +47,13 @@ jobs: renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "${renamed_redirect//\$\\\$}" $REDIRECTS_FILE; then - echo "Target file: $REDIRECTS_FILE" - echo "Target string: $renamed_redirect" - grep "$renamed_redirect" $REDIRECTS_FILE + if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then renamed_redirects+=("$renamed_redirect") fi + + if grep -q "/fundamentals/renamed/" $REDIRECTS_FILE; then + echo "found" + fi done echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" From 1a430a934af6072294b5bd6a41c913be2519f068 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 13:58:47 -0500 Subject: [PATCH 10/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index a7000a1b..56b2cfa7 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -51,6 +51,7 @@ jobs: renamed_redirects+=("$renamed_redirect") fi + cat "$REDIRECTS_FILE" if grep -q "/fundamentals/renamed/" $REDIRECTS_FILE; then echo "found" fi From 72b61f2f2c4e2f9729ede1f33c4bc588ae9ad9c6 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 14:05:41 -0500 Subject: [PATCH 11/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 56b2cfa7..e8998847 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -8,18 +8,28 @@ jobs: name: Verifying Redirects runs-on: ubuntu-latest env: - REDIRECTS_FILE: "config/redirects" + REDIRECTS_FILE: "pr/config/redirects" permissions: pull-requests: write steps: - - name: Check Out Code + - name: Check Out Base Branch uses: actions/checkout@v4 + with: + ref: ${{ github.event.pull_request.base.ref }} + path: base + + - name: Check Out PR Branch + uses: actions/checkout@v4 + with: + ref: ${{ github.event.pull_request.head.ref }} + path: pr - name: Get Changed Files id: changed-files uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c with: include_all_old_new_renamed_files: true + path: pr - name: Find Missing Redirects for Renamed Files id: renamed-files From 8d0f6792a46df02746417742b28e905788644163 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 14:09:25 -0500 Subject: [PATCH 12/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index e8998847..5be8d2fe 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -11,6 +11,7 @@ jobs: REDIRECTS_FILE: "pr/config/redirects" permissions: pull-requests: write + contents: read steps: - name: Check Out Base Branch uses: actions/checkout@v4 From faa5f9384e4e747f5f9c1871908015a5bb757f93 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 14:11:21 -0500 Subject: [PATCH 13/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 5be8d2fe..8e50b023 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -8,22 +8,13 @@ jobs: name: Verifying Redirects runs-on: ubuntu-latest env: - REDIRECTS_FILE: "pr/config/redirects" + REDIRECTS_FILE: "config/redirects" permissions: pull-requests: write contents: read steps: - name: Check Out Base Branch uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.base.ref }} - path: base - - - name: Check Out PR Branch - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.ref }} - path: pr - name: Get Changed Files id: changed-files @@ -61,12 +52,6 @@ jobs: if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then renamed_redirects+=("$renamed_redirect") fi - - cat "$REDIRECTS_FILE" - if grep -q "/fundamentals/renamed/" $REDIRECTS_FILE; then - echo "found" - fi - done echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" From 83164a9e73212200fccc9a01288797ac7c158482 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 14:44:40 -0500 Subject: [PATCH 14/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 8e50b023..486066a6 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -1,4 +1,4 @@ -name: Redirector +name: Verify Redirects on: pull_request_target: @@ -11,7 +11,6 @@ jobs: REDIRECTS_FILE: "config/redirects" permissions: pull-requests: write - contents: read steps: - name: Check Out Base Branch uses: actions/checkout@v4 @@ -21,7 +20,6 @@ jobs: uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c with: include_all_old_new_renamed_files: true - path: pr - name: Find Missing Redirects for Renamed Files id: renamed-files @@ -93,8 +91,6 @@ jobs: run: | # empty string that stays empty if there are no redirects to suggest redirect_html="" - echo "RENAMED_REDIRECTS: $RENAMED_REDIRECTS" - echo "renamed output: ${{ steps.renamed-files.outputs.redirects }}" for renamed_redirect in "${RENAMED_REDIRECTS[@]}"; do redirect_html+="
  • [<v>-*]: $renamed_redirect
  • " From ac36973290a77a867dde128e880964489ae9c190 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 14:45:11 -0500 Subject: [PATCH 15/60] Update redirects --- config/redirects | 1 + 1 file changed, 1 insertion(+) diff --git a/config/redirects b/config/redirects index 9351a914..240b29f9 100644 --- a/config/redirects +++ b/config/redirects @@ -15,6 +15,7 @@ raw: ${prefix}/master -> ${base}/upcoming/ [*-master]: ${prefix}/${version}/fundamentals/data-formats/bson/ -> ${base}/${version}/fundamentals/bson/ [*-master]: ${prefix}/${version}/fundamentals/class-mapping/ -> ${base}/${version}/fundamentals/serialization/class-mapping/ [*-v2.30]: ${prefix}/${version}/upgrade/v2/ -> ${base}/${version}/upgrade/ +[*-v2.30]: ${prefix}/${version}/upgrade/v2/ -> ${base}/${version}/upgrade/ [*-v2.30]: ${prefix}/${version}/upgrade/v3/ -> ${base}/${version}/upgrade/ [*-master]: ${prefix}/${version}/fundamentals/crud/write-operations/modify/#replace-operation -> ${base}/${version}/fundamentals/crud/write-operations/replace/ [*-master]: ${prefix}/${version}/fundamentals/crud/write-operations/modify/ -> ${base}/${version}/fundamentals/crud/write-operations/ From 63a7dd54c1e3ff4e172e89e1089bee461692a285 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:25:18 -0500 Subject: [PATCH 16/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 486066a6..4dd03cd3 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -14,7 +14,15 @@ jobs: steps: - name: Check Out Base Branch uses: actions/checkout@v4 - + + - name: Checkout PR Head Branch + uses: actions/checkout@v4 + with: + token: ${{ secrets.GITHUB_TOKEN }} + ref: ${{ github.event.pull_request.head.ref }} + repository: ${{ github.event.pull_request.head.repo.full_name }} + path: pr + - name: Get Changed Files id: changed-files uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c From 8334b7230fea9a37a09bb8f7ffa6e071a6053226 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:26:36 -0500 Subject: [PATCH 17/60] Update redirects --- config/redirects | 1 - 1 file changed, 1 deletion(-) diff --git a/config/redirects b/config/redirects index 240b29f9..9351a914 100644 --- a/config/redirects +++ b/config/redirects @@ -15,7 +15,6 @@ raw: ${prefix}/master -> ${base}/upcoming/ [*-master]: ${prefix}/${version}/fundamentals/data-formats/bson/ -> ${base}/${version}/fundamentals/bson/ [*-master]: ${prefix}/${version}/fundamentals/class-mapping/ -> ${base}/${version}/fundamentals/serialization/class-mapping/ [*-v2.30]: ${prefix}/${version}/upgrade/v2/ -> ${base}/${version}/upgrade/ -[*-v2.30]: ${prefix}/${version}/upgrade/v2/ -> ${base}/${version}/upgrade/ [*-v2.30]: ${prefix}/${version}/upgrade/v3/ -> ${base}/${version}/upgrade/ [*-master]: ${prefix}/${version}/fundamentals/crud/write-operations/modify/#replace-operation -> ${base}/${version}/fundamentals/crud/write-operations/replace/ [*-master]: ${prefix}/${version}/fundamentals/crud/write-operations/modify/ -> ${base}/${version}/fundamentals/crud/write-operations/ From 41e66a3f4e11084924f82427c4b014afdf3ecd89 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:28:02 -0500 Subject: [PATCH 18/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 4dd03cd3..01d37128 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -8,7 +8,7 @@ jobs: name: Verifying Redirects runs-on: ubuntu-latest env: - REDIRECTS_FILE: "config/redirects" + REDIRECTS_FILE: "pr/config/redirects" permissions: pull-requests: write steps: From 4d4680961f021a4f788bab7890c2b34ac62d4f6e Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:31:53 -0500 Subject: [PATCH 19/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 01d37128..a288a033 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -37,7 +37,7 @@ jobs: run: | renamed_redirects=() for file in $RENAMED_FILES; do - + echo "iteration" # only run for .txt files if [[ ! "$file" == *.txt ]]; then continue @@ -56,6 +56,7 @@ jobs: # if redirect not already in file, add to array to add to PR description if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + echo "adding string $renamed_direct to array" renamed_redirects+=("$renamed_redirect") fi done From c96b402e4cb2f81c41d9824728fe8d55ca4a3ebe Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:35:59 -0500 Subject: [PATCH 20/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index a288a033..58576bf5 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -37,7 +37,7 @@ jobs: run: | renamed_redirects=() for file in $RENAMED_FILES; do - echo "iteration" + # only run for .txt files if [[ ! "$file" == *.txt ]]; then continue @@ -56,7 +56,6 @@ jobs: # if redirect not already in file, add to array to add to PR description if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then - echo "adding string $renamed_direct to array" renamed_redirects+=("$renamed_redirect") fi done @@ -100,13 +99,11 @@ jobs: run: | # empty string that stays empty if there are no redirects to suggest redirect_html="" + combined_redirect_array=("${RENAMED_REDIRECTS[@]}" "${DELETED_REDIRECTS[@]}") - for renamed_redirect in "${RENAMED_REDIRECTS[@]}"; do - redirect_html+="
  • [<v>-*]: $renamed_redirect
  • " - done - - for deleted_redirect in "${DELETED_REDIRECTS[@]}"; do - redirect_html+="
  • [<v>-*]: $deleted_redirect
  • " + for redirect in "${combined_redirect_array[@]}"; do + echo "adding" + redirect_html+="
  • [<v>-*]: $redirect
  • " done echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" From 2c16534347ef7e444bfc5afe9a8941b16c6760e5 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:38:58 -0500 Subject: [PATCH 21/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 58576bf5..45533f1e 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -100,9 +100,8 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" combined_redirect_array=("${RENAMED_REDIRECTS[@]}" "${DELETED_REDIRECTS[@]}") - + echo "array length: ${#combined_redirect_array[@]}" for redirect in "${combined_redirect_array[@]}"; do - echo "adding" redirect_html+="
  • [<v>-*]: $redirect
  • " done From 3c3aefc69ac82d9231bcd769b95bb18c15964cc5 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:41:36 -0500 Subject: [PATCH 22/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 45533f1e..96e5996b 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -36,6 +36,7 @@ jobs: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | renamed_redirects=() + echo "first length: ${#renamed_redirects[@]}" for file in $RENAMED_FILES; do # only run for .txt files @@ -59,6 +60,7 @@ jobs: renamed_redirects+=("$renamed_redirect") fi done + echo "second length: ${#renamed_redirects[@]}" echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files From ad9e151ad5e916b8ffe1b0c4fa98972f31b07221 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:43:39 -0500 Subject: [PATCH 23/60] Delete .github/workflows/vale-tdbx.yml --- .github/workflows/vale-tdbx.yml | 42 --------------------------------- 1 file changed, 42 deletions(-) delete mode 100644 .github/workflows/vale-tdbx.yml diff --git a/.github/workflows/vale-tdbx.yml b/.github/workflows/vale-tdbx.yml deleted file mode 100644 index 8e4b6f49..00000000 --- a/.github/workflows/vale-tdbx.yml +++ /dev/null @@ -1,42 +0,0 @@ -name: vale-checks -on: - pull_request: - paths: - - "source/**" - -jobs: - vale: - name: TDBX Vale rules - runs-on: ubuntu-latest - steps: - - name: checkout - uses: actions/checkout@master - - - name: Install docutils - run: sudo apt-get install -y docutils - - - id: files - uses: masesgroup/retrieve-changed-files@v2 - with: - format: 'csv' - - - name: checkout-latest-rules - uses: actions/checkout@master - with: - repository: mongodb/mongodb-vale-action - path: './tdbx-vale-rules' - token: ${{secrets.GITHUB_TOKEN}} - - - name: move-files-for-vale-action - run: | - cp tdbx-vale-rules/.vale.ini .vale.ini - mkdir -p .github/styles/ - cp -rf tdbx-vale-rules/.github/styles/ .github/ - - - name: run-vale - uses: errata-ai/vale-action@reviewdog - with: - reporter: github-pr-check - files: ${{steps.files.outputs.added_modified}} - fail_on_error: true - token: ${{secrets.GITHUB_TOKEN}} From 33937f9c614bcd567ff43a837ca874bf490d8997 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:43:48 -0500 Subject: [PATCH 24/60] Delete .github/workflows/add-netlify-links.yml --- .github/workflows/add-netlify-links.yml | 58 ------------------------- 1 file changed, 58 deletions(-) delete mode 100644 .github/workflows/add-netlify-links.yml diff --git a/.github/workflows/add-netlify-links.yml b/.github/workflows/add-netlify-links.yml deleted file mode 100644 index 69377f9f..00000000 --- a/.github/workflows/add-netlify-links.yml +++ /dev/null @@ -1,58 +0,0 @@ -name: Add Netlify Links To Changed Pages -on: - workflow_call: - pull_request_target: -jobs: - get-pr-changes: - name: Get Changed Files & Update PR Description - runs-on: ubuntu-latest - permissions: - issues: write - contents: write - pull-requests: write - repository-projects: write - steps: - - uses: actions/checkout@v4 - - name: Get Changed Files - id: changed-files - # pin to a specific commit to ensure stability - uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c - with: - separator: "," - files: source/** - - name: Build Netlify Links for Changed Pages - id: build_page_links - env: - CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} - run: | - new_links="" - base_link='https://deploy-preview-${{ github.event.number }}--docs-csharp.netlify.app' - files=$(echo "$CHANGED_FILES" | tr "," "\n") - for file in $files; do - echo "processing ${file}" - if (! grep -s "includes/" <<< "$file") && - (! grep -s "images/" <<< "$file") && - (! grep -s "examples/" <<< "$file"); then - file="${file#source}" - file="${file%.txt}" - filenoslash="${file:1}" - echo "${base_link}${file}" - new_links+="
  • ${filenoslash}
  • " - else - echo "(file skipped)" - fi - done - if [ "$new_links" == "" ]; then - new_links="No pages to preview" - fi - echo "Final new_links string: " - echo "${new_links}" - echo "staging_links=${new_links}" >> "$GITHUB_OUTPUT" - - name: Update the PR Description - uses: MongoCaleb/pr-description-action@master - with: - regex: ".*" - appendContentOnMatchOnly: true - regexFlags: is - content: "\n${{ steps.build_page_links.outputs.staging_links }}\n" - token: ${{ secrets.GITHUB_TOKEN }} From 73cb3e09bf2f835350f970e435f4aa5f561c56b5 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:44:28 -0500 Subject: [PATCH 25/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 96e5996b..e01f16ea 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -70,6 +70,7 @@ jobs: DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} run: | deleted_redirects=() + echo "first length: ${#renamed_redirects[@]}" for file in $DELETED_FILES; do # only run for .txt files @@ -91,6 +92,7 @@ jobs: fi done + echo "second length: ${#renamed_redirects[@]}" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML From 3073b2693c85f44f01e4271f8be34a7dc217ec49 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:46:25 -0500 Subject: [PATCH 26/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index e01f16ea..c3495d31 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -87,12 +87,13 @@ jobs: deleted_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then + if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then + echo "adding $deleted_redirect" deleted_redirects+=("$deleted_redirect") fi done - echo "second length: ${#renamed_redirects[@]}" + echo "second length: ${#deleted_redirects[@]}" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML From 223efbc5c24de84581139ec778ef2f2868fe7968 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:49:05 -0500 Subject: [PATCH 27/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index c3495d31..fd70ee8d 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -36,7 +36,6 @@ jobs: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | renamed_redirects=() - echo "first length: ${#renamed_redirects[@]}" for file in $RENAMED_FILES; do # only run for .txt files @@ -60,7 +59,6 @@ jobs: renamed_redirects+=("$renamed_redirect") fi done - echo "second length: ${#renamed_redirects[@]}" echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -70,7 +68,6 @@ jobs: DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} run: | deleted_redirects=() - echo "first length: ${#renamed_redirects[@]}" for file in $DELETED_FILES; do # only run for .txt files @@ -88,12 +85,10 @@ jobs: # if redirect not already in file, add to array to add to PR description if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then - echo "adding $deleted_redirect" deleted_redirects+=("$deleted_redirect") fi done - echo "second length: ${#deleted_redirects[@]}" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML @@ -105,7 +100,9 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" combined_redirect_array=("${RENAMED_REDIRECTS[@]}" "${DELETED_REDIRECTS[@]}") - echo "array length: ${#combined_redirect_array[@]}" + echo "renamed array length: ${#RENAMED_REDIRECTS[@]}" + echo "deleted array length: ${#DELETED_REDIRECTS[@]}" + echo "combined array length: ${#combined_redirect_array[@]}" for redirect in "${combined_redirect_array[@]}"; do redirect_html+="
  • [<v>-*]: $redirect
  • " done From 76a2611f3354873f45aca092cd7674b9abe1c6f8 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 15:52:24 -0500 Subject: [PATCH 28/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index fd70ee8d..961f232e 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -56,10 +56,12 @@ jobs: # if redirect not already in file, add to array to add to PR description if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then + echo "adding $renamed_direct to redirects array" renamed_redirects+=("$renamed_redirect") fi done echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" + cat "$REDIRECTS_FILE" - name: Find Missing Redirects for Deleted Files id: deleted-files From af5681cf428e878adc32f3d074c223ea2378e427 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:00:46 -0500 Subject: [PATCH 29/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 961f232e..e1be6da0 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -101,6 +101,7 @@ jobs: run: | # empty string that stays empty if there are no redirects to suggest redirect_html="" + echo "length of init value: ${{ steps.renamed-files.outputs.redirects }}" combined_redirect_array=("${RENAMED_REDIRECTS[@]}" "${DELETED_REDIRECTS[@]}") echo "renamed array length: ${#RENAMED_REDIRECTS[@]}" echo "deleted array length: ${#DELETED_REDIRECTS[@]}" From ea904903d4b5e9340fa0183e8e9fe5a84d4e73a8 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:05:32 -0500 Subject: [PATCH 30/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index e1be6da0..493ad3ad 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -101,15 +101,14 @@ jobs: run: | # empty string that stays empty if there are no redirects to suggest redirect_html="" - echo "length of init value: ${{ steps.renamed-files.outputs.redirects }}" - combined_redirect_array=("${RENAMED_REDIRECTS[@]}" "${DELETED_REDIRECTS[@]}") + echo "renamed array length: ${#RENAMED_REDIRECTS[@]}" echo "deleted array length: ${#DELETED_REDIRECTS[@]}" - echo "combined array length: ${#combined_redirect_array[@]}" - for redirect in "${combined_redirect_array[@]}"; do + + for redirect in "${{ steps.renamed-files.outputs.redirects[@] }}"; do redirect_html+="
  • [<v>-*]: $redirect
  • " done - + echo "$redirect_html" echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - name: Update PR Description From 76963dcca5fe20f4713a1f0ba64f0d88e134804d Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:16:59 -0500 Subject: [PATCH 31/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 493ad3ad..65e53f99 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -60,8 +60,9 @@ jobs: renamed_redirects+=("$renamed_redirect") fi done - echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - cat "$REDIRECTS_FILE" + + IFS=',' # Set the delimiter to export as a string + echo "redirects=${renamed_redirects[*]}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files id: deleted-files @@ -89,9 +90,10 @@ jobs: if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then deleted_redirects+=("$deleted_redirect") fi - done - echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" + + IFS=',' # Set the delimiter to export as a string + echo "redirects=${deleted_redirects[*]}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML id: build-redirect-html @@ -102,13 +104,15 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" - echo "renamed array length: ${#RENAMED_REDIRECTS[@]}" - echo "deleted array length: ${#DELETED_REDIRECTS[@]}" + # convert exported strings back to arrays + combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" + IFS=',' + read -ra combined_redirect_array <<< "$combined_redirect_string" # Split the string into an array - for redirect in "${{ steps.renamed-files.outputs.redirects[@] }}"; do + for redirect in "${combined_redirect_array[@]}"; do redirect_html+="
  • [<v>-*]: $redirect
  • " done - echo "$redirect_html" + echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - name: Update PR Description From cf7820a2e9b5bdafebe593eef2b2e0f630d85d2a Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:24:19 -0500 Subject: [PATCH 32/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 33 +++++++++++++------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 65e53f99..214d3e2d 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -35,7 +35,7 @@ jobs: env: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | - renamed_redirects=() + renamed_redirects="" for file in $RENAMED_FILES; do # only run for .txt files @@ -52,17 +52,17 @@ jobs: new="${new%.txt}" # single quotes = ${var} rendered literally; double quotes = $var interpreted - renamed_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' + redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' - # if redirect not already in file, add to array to add to PR description - if ! grep -q "$renamed_redirect" $REDIRECTS_FILE; then - echo "adding $renamed_direct to redirects array" - renamed_redirects+=("$renamed_redirect") + # if redirect not already in file, add to string to add to PR description + if ! grep -q "$redirect" $REDIRECTS_FILE; then + renamed_redirects+="$redirect," fi done - IFS=',' # Set the delimiter to export as a string - echo "redirects=${renamed_redirects[*]}" >> "$GITHUB_OUTPUT" + # cut trailing comma + renamed_redirects="${renamed_redirects%,}" + echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files id: deleted-files @@ -70,7 +70,7 @@ jobs: env: DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} run: | - deleted_redirects=() + deleted_redirects="" for file in $DELETED_FILES; do # only run for .txt files @@ -84,16 +84,17 @@ jobs: old="${old%.txt}" # single quotes = ${var} rendered literally; double quotes = $var interpreted - deleted_redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' + redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' # if redirect not already in file, add to array to add to PR description - if ! grep -q "$deleted_redirect" $REDIRECTS_FILE; then - deleted_redirects+=("$deleted_redirect") + if ! grep -q "$redirect" $REDIRECTS_FILE; then + deleted_redirects+="$redirect," fi done - - IFS=',' # Set the delimiter to export as a string - echo "redirects=${deleted_redirects[*]}" >> "$GITHUB_OUTPUT" + + # cut trailing comma + deleted_redirects="${renamed_redirects%,}" + echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML id: build-redirect-html @@ -104,7 +105,7 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" - # convert exported strings back to arrays + # convert exported strings to arrays combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" IFS=',' read -ra combined_redirect_array <<< "$combined_redirect_string" # Split the string into an array From 220bbdceb0efa6908a10bf32362ba7aa4e0f58f2 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:26:00 -0500 Subject: [PATCH 33/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 214d3e2d..77e390e2 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -62,6 +62,7 @@ jobs: # cut trailing comma renamed_redirects="${renamed_redirects%,}" + echo "$renamed_redirects" echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -94,6 +95,7 @@ jobs: # cut trailing comma deleted_redirects="${renamed_redirects%,}" + echo "$deleted_redirects" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML @@ -115,6 +117,7 @@ jobs: done echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" + echo "$redirect_html" - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html From 4cee4d817b7682b6e763841addaba20c974769fc Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:28:03 -0500 Subject: [PATCH 34/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 77e390e2..687205e8 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -94,7 +94,7 @@ jobs: done # cut trailing comma - deleted_redirects="${renamed_redirects%,}" + deleted_redirects="${deleted_redirects%,}" echo "$deleted_redirects" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" @@ -113,6 +113,7 @@ jobs: read -ra combined_redirect_array <<< "$combined_redirect_string" # Split the string into an array for redirect in "${combined_redirect_array[@]}"; do + echo "adding html for $redirect now" redirect_html+="
  • [<v>-*]: $redirect
  • " done From fa7c2240677eb1783f6a51feb72819884661e79b Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:35:09 -0500 Subject: [PATCH 35/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 687205e8..d0514b50 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -107,14 +107,13 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" - # convert exported strings to arrays combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" IFS=',' - read -ra combined_redirect_array <<< "$combined_redirect_string" # Split the string into an array - - for redirect in "${combined_redirect_array[@]}"; do - echo "adding html for $redirect now" - redirect_html+="
  • [<v>-*]: $redirect
  • " + echo "combined string: $combined_redirect_string" + for redirect in "$combined_redirect_string"; do + if [[ ! -z "$redirect" ]]; then + redirect_html+="
  • [<v>-*]: $redirect
  • " + fi done echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" From d856808b04c1db00c3e38e028cd09a7754f10ba3 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:37:01 -0500 Subject: [PATCH 36/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index d0514b50..060bb6d5 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -107,6 +107,9 @@ jobs: # empty string that stays empty if there are no redirects to suggest redirect_html="" + echo "renamed: $RENAMED_REDIRECTS" + echo "deleted: $DELETED_REDIRECTS" + combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" IFS=',' echo "combined string: $combined_redirect_string" From 8c77462e95da4e54c83f307a36498fefda08f6a7 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:41:50 -0500 Subject: [PATCH 37/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 060bb6d5..42cbf014 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -114,6 +114,7 @@ jobs: IFS=',' echo "combined string: $combined_redirect_string" for redirect in "$combined_redirect_string"; do + echo "redirect in loop: $redirect" if [[ ! -z "$redirect" ]]; then redirect_html+="
  • [<v>-*]: $redirect
  • " fi From bb05ada2699d8dc15b1684476b03b2d286e8f650 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:45:32 -0500 Subject: [PATCH 38/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 42cbf014..55056510 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -106,22 +106,16 @@ jobs: run: | # empty string that stays empty if there are no redirects to suggest redirect_html="" - - echo "renamed: $RENAMED_REDIRECTS" - echo "deleted: $DELETED_REDIRECTS" - + combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" IFS=',' - echo "combined string: $combined_redirect_string" - for redirect in "$combined_redirect_string"; do - echo "redirect in loop: $redirect" + for redirect in $combined_redirect_string; do if [[ ! -z "$redirect" ]]; then redirect_html+="
  • [<v>-*]: $redirect
  • " fi done echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - echo "$redirect_html" - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html From 39203a592cbbaa5fb657421e1861551a767e3d74 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:46:59 -0500 Subject: [PATCH 39/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 55056510..7cb2c056 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -62,7 +62,7 @@ jobs: # cut trailing comma renamed_redirects="${renamed_redirects%,}" - echo "$renamed_redirects" + echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -95,7 +95,7 @@ jobs: # cut trailing comma deleted_redirects="${deleted_redirects%,}" - echo "$deleted_redirects" + echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML From 163d08105cf26882646e8bef95be8a4cb749e828 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:48:42 -0500 Subject: [PATCH 40/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 7cb2c056..da394e84 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -126,7 +126,7 @@ jobs: regex: "- \\[ \\] Did you add redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ steps.build-redirect-html.outputs.redirect_html }}\n" + content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${REDIRECT_HTML}\n" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From b8aa27fdd3784b72ab85be975a16b05c2566def7 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:51:55 -0500 Subject: [PATCH 41/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index da394e84..96a5e023 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -126,7 +126,7 @@ jobs: regex: "- \\[ \\] Did you add redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${REDIRECT_HTML}\n" + content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ REDIRECT_HTML }}\n" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From 306e19ceffb7201338e606b8e7dc58f19e32dabe Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 16:53:04 -0500 Subject: [PATCH 42/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 96a5e023..5a517ff1 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -120,13 +120,11 @@ jobs: - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html uses: MongoCaleb/pr-description-action@4bdfe35b98f64532b419ad20b350a92546cd3aa1 - env: - REDIRECT_HTML: ${{ steps.build-redirect-html.outputs.redirect_html }} with: regex: "- \\[ \\] Did you add redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ REDIRECT_HTML }}\n" + content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ steps.build-redirect-html.outputs.redirect_html }}\n" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From 505bdbd2f45cf915ef899dc88b520c56e3daefa2 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:00:59 -0500 Subject: [PATCH 43/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 5a517ff1..6ece1330 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -114,8 +114,8 @@ jobs: redirect_html+="
  • [<v>-*]: $redirect
  • " fi done - - echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" + + echo "redirect_html=- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n$redirect_html\n" >> "$GITHUB_OUTPUT" - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html @@ -124,7 +124,7 @@ jobs: regex: "- \\[ \\] Did you add redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n${{ steps.build-redirect-html.outputs.redirect_html }}\n" + content: ${{ steps.build-redirect-html.outputs.redirect_html }} token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From 7c048b5ec759dec0df409abbb7d749a03077a868 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:03:25 -0500 Subject: [PATCH 44/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 6ece1330..1d292853 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -115,7 +115,7 @@ jobs: fi done - echo "redirect_html=- [ ] Did you add redirects?\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\n$redirect_html\n" >> "$GITHUB_OUTPUT" + echo "redirect_html=- [ ] Did you add redirects?\\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\\n$redirect_html\\n" >> "$GITHUB_OUTPUT" - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html From dda91fff61039d6b8690dee669fc58cf537befdb Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:04:58 -0500 Subject: [PATCH 45/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 1d292853..92fa6ee5 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -115,7 +115,10 @@ jobs: fi done - echo "redirect_html=- [ ] Did you add redirects?\\n *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*\\n$redirect_html\\n" >> "$GITHUB_OUTPUT" + echo "redirect_html=- [ ] Did you add redirects? + *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):* + $redirect_html + " >> "$GITHUB_OUTPUT" - name: Update PR Description if: steps.build-redirect-html.outputs.redirect_html From 5ff77f2c89e7cd751b9485552896462cb13dc021 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:11:52 -0500 Subject: [PATCH 46/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 92fa6ee5..0a8cd3d5 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -108,26 +108,27 @@ jobs: redirect_html="" combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - IFS=',' - for redirect in $combined_redirect_string; do - if [[ ! -z "$redirect" ]]; then - redirect_html+="
  • [<v>-*]: $redirect
  • " - fi - done - echo "redirect_html=- [ ] Did you add redirects? - *Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):* - $redirect_html - " >> "$GITHUB_OUTPUT" + # count number of values and add intro text if there are any to show + if [[ $(( $(grep -o "," <<< "$combined_redirect_string" | wc -l) )) > 1 ]]; then + redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" + IFS=',' + for redirect in $combined_redirect_string; do + if [[ ! -z "$redirect" ]]; then + redirect_html+="
  • [<v>-*]: $redirect
  • " + fi + done + fi + + echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - name: Update PR Description - if: steps.build-redirect-html.outputs.redirect_html uses: MongoCaleb/pr-description-action@4bdfe35b98f64532b419ad20b350a92546cd3aa1 with: regex: "- \\[ \\] Did you add redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: ${{ steps.build-redirect-html.outputs.redirect_html }} + content: "- [ ] Did you add redirects?\n ${{ steps.build-redirect-html.outputs.redirect_html }}" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From 70f4f8a057f0a4cfc63a32b1958c7db66c5f584a Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:19:20 -0500 Subject: [PATCH 47/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 0a8cd3d5..e3c50d5f 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -109,16 +109,15 @@ jobs: combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - # count number of values and add intro text if there are any to show - if [[ $(( $(grep -o "," <<< "$combined_redirect_string" | wc -l) )) > 1 ]]; then - redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" - IFS=',' - for redirect in $combined_redirect_string; do - if [[ ! -z "$redirect" ]]; then - redirect_html+="
  • [<v>-*]: $redirect
  • " - fi - done - fi + IFS=',' + for redirect in $combined_redirect_string; do + if [[ ! -z "$redirect" ]]; then + if [[ redirect_html="" ]]; then + redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" + fi + redirect_html+="
  • [<v>-*]: $redirect
  • " + fi + done echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" From d5f20f67412b9d64efeeafaba77d667c4b57a7a4 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:24:11 -0500 Subject: [PATCH 48/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index e3c50d5f..d4ed1824 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -87,7 +87,7 @@ jobs: # single quotes = ${var} rendered literally; double quotes = $var interpreted redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' - # if redirect not already in file, add to array to add to PR description + # if redirect not already in file, add to string to add to PR description if ! grep -q "$redirect" $REDIRECTS_FILE; then deleted_redirects+="$redirect," fi @@ -109,7 +109,6 @@ jobs: combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - IFS=',' for redirect in $combined_redirect_string; do if [[ ! -z "$redirect" ]]; then if [[ redirect_html="" ]]; then From 3d7d0c1032a4c3c870e31d08302dc33a68b583a3 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Thu, 15 May 2025 17:27:07 -0500 Subject: [PATCH 49/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index d4ed1824..97de2805 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -131,16 +131,13 @@ jobs: - name: Check for duplicates in redirects file run: | - # Specify the file to check - file="$REDIRECTS_FILE" - - if [[ -f "$file" ]]; then - duplicates=$(sort "$file" | uniq -d) + if [[ -f "$REDIRECTS_FILE" ]]; then + duplicates=$(sort "$REDIRECTS_FILE" | uniq -d) if [[ -n "$duplicates" ]]; then - echo "Duplicate lines found in $file:" + echo "Duplicate lines found in $REDIRECTS_FILE:" echo "$duplicates" exit 1 # error fi else - echo "File $file does not exist. Skipping duplicate check." + echo "Redirects file doesn't exist. Skipping duplicate check." fi From 0bed87a971a213a32a5c631b80f79e84d15b0ad6 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 09:27:02 -0500 Subject: [PATCH 50/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 97de2805..b9399c99 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -36,6 +36,7 @@ jobs: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | renamed_redirects="" + echo "changed-files renamed list: $RENAMED_FILES" for file in $RENAMED_FILES; do # only run for .txt files @@ -56,13 +57,14 @@ jobs: # if redirect not already in file, add to string to add to PR description if ! grep -q "$redirect" $REDIRECTS_FILE; then + echo "adding $redirect to renamed_redirects variable" renamed_redirects+="$redirect," fi done # cut trailing comma renamed_redirects="${renamed_redirects%,}" - + echo "passing $renamed_redirects to github output" echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -72,6 +74,7 @@ jobs: DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} run: | deleted_redirects="" + echo "changed-files deleted list: $DELETED_FILES" for file in $DELETED_FILES; do # only run for .txt files @@ -89,13 +92,14 @@ jobs: # if redirect not already in file, add to string to add to PR description if ! grep -q "$redirect" $REDIRECTS_FILE; then + echo "adding $redirect to deleted_redirects variable" deleted_redirects+="$redirect," fi done # cut trailing comma deleted_redirects="${deleted_redirects%,}" - + echo "passing $deleted_redirects to github output" echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML @@ -108,7 +112,7 @@ jobs: redirect_html="" combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - + echo "combined-redirect-string: $combined_redirect_string" for redirect in $combined_redirect_string; do if [[ ! -z "$redirect" ]]; then if [[ redirect_html="" ]]; then @@ -117,7 +121,8 @@ jobs: redirect_html+="
  • [<v>-*]: $redirect
  • " fi done - + + echo "redirect html: $redirect_html" echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - name: Update PR Description From a11196d9bfceae7770124e57a0c1107d0832a60e Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 09:46:59 -0500 Subject: [PATCH 51/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index b9399c99..1ddea34f 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -114,10 +114,13 @@ jobs: combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" echo "combined-redirect-string: $combined_redirect_string" for redirect in $combined_redirect_string; do + echo "running one iteration of the loop" if [[ ! -z "$redirect" ]]; then if [[ redirect_html="" ]]; then + echo "adding redirect intro text" redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" fi + echo "adding $redirect to redirect_html variable" redirect_html+="
  • [<v>-*]: $redirect
  • " fi done From eda9c8aeeb6c8a598f9471d9719a516bb13f60bd Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 09:50:27 -0500 Subject: [PATCH 52/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 1ddea34f..54c4ff5c 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -116,7 +116,7 @@ jobs: for redirect in $combined_redirect_string; do echo "running one iteration of the loop" if [[ ! -z "$redirect" ]]; then - if [[ redirect_html="" ]]; then + if [[ -z "$redirect_html" ]]; then echo "adding redirect intro text" redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" fi From bcf43e93e29aa5ae25d2dec170e5bf73e428607e Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 09:52:52 -0500 Subject: [PATCH 53/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 54c4ff5c..72257a67 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -113,6 +113,7 @@ jobs: combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" echo "combined-redirect-string: $combined_redirect_string" + IFS=',' for redirect in $combined_redirect_string; do echo "running one iteration of the loop" if [[ ! -z "$redirect" ]]; then From 90bdf529af9a140495f1eb85bceb8ec70aed4427 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 09:58:42 -0500 Subject: [PATCH 54/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 72257a67..f5960c6d 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -119,10 +119,10 @@ jobs: if [[ ! -z "$redirect" ]]; then if [[ -z "$redirect_html" ]]; then echo "adding redirect intro text" - redirect_html="*Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):*" + redirect_html="Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):" fi echo "adding $redirect to redirect_html variable" - redirect_html+="
  • [<v>-*]: $redirect
  • " + redirect_html+="
  • [<v>-\*]: $redirect
  • " fi done From e96884c59ebd13836d965adef73fd1cf4639c5b3 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 10:01:57 -0500 Subject: [PATCH 55/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index f5960c6d..132b1fd7 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -36,7 +36,7 @@ jobs: RENAMED_FILES: ${{ steps.changed-files.outputs.all_old_new_renamed_files }} run: | renamed_redirects="" - echo "changed-files renamed list: $RENAMED_FILES" + for file in $RENAMED_FILES; do # only run for .txt files @@ -57,14 +57,13 @@ jobs: # if redirect not already in file, add to string to add to PR description if ! grep -q "$redirect" $REDIRECTS_FILE; then - echo "adding $redirect to renamed_redirects variable" renamed_redirects+="$redirect," fi done # cut trailing comma renamed_redirects="${renamed_redirects%,}" - echo "passing $renamed_redirects to github output" + echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -74,7 +73,7 @@ jobs: DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }} run: | deleted_redirects="" - echo "changed-files deleted list: $DELETED_FILES" + for file in $DELETED_FILES; do # only run for .txt files @@ -92,14 +91,13 @@ jobs: # if redirect not already in file, add to string to add to PR description if ! grep -q "$redirect" $REDIRECTS_FILE; then - echo "adding $redirect to deleted_redirects variable" deleted_redirects+="$redirect," fi done # cut trailing comma deleted_redirects="${deleted_redirects%,}" - echo "passing $deleted_redirects to github output" + echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML @@ -112,21 +110,17 @@ jobs: redirect_html="" combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - echo "combined-redirect-string: $combined_redirect_string" + IFS=',' for redirect in $combined_redirect_string; do - echo "running one iteration of the loop" if [[ ! -z "$redirect" ]]; then if [[ -z "$redirect_html" ]]; then - echo "adding redirect intro text" redirect_html="Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):" fi - echo "adding $redirect to redirect_html variable" redirect_html+="
  • [<v>-\*]: $redirect
  • " fi done - echo "redirect html: $redirect_html" echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" - name: Update PR Description @@ -148,5 +142,5 @@ jobs: exit 1 # error fi else - echo "Redirects file doesn't exist. Skipping duplicate check." + "Redirects file doesn't exist. Skipping duplicate check." fi From ae9f40baa2a32c62060a7fc933837600e77654a7 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 10:04:46 -0500 Subject: [PATCH 56/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 132b1fd7..a259678b 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -56,7 +56,7 @@ jobs: redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to string to add to PR description - if ! grep -q "$redirect" $REDIRECTS_FILE; then + if ! grep -qx "$redirect" $REDIRECTS_FILE; then renamed_redirects+="$redirect," fi done @@ -90,7 +90,7 @@ jobs: redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' # if redirect not already in file, add to string to add to PR description - if ! grep -q "$redirect" $REDIRECTS_FILE; then + if ! grep -qx "$redirect" $REDIRECTS_FILE; then deleted_redirects+="$redirect," fi done From e36ab587d34386a988491c6a1bfcc91d1da2c383 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 11:42:54 -0500 Subject: [PATCH 57/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 32 +++++++------------------- 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index a259678b..4adeeb10 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -52,18 +52,14 @@ jobs: new="${new#source}" new="${new%.txt}" - # single quotes = ${var} rendered literally; double quotes = $var interpreted redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to string to add to PR description if ! grep -qx "$redirect" $REDIRECTS_FILE; then - renamed_redirects+="$redirect," + renamed_redirects+="
  • [<v>-*]: $redirect
  • " fi done - # cut trailing comma - renamed_redirects="${renamed_redirects%,}" - echo "redirects=${renamed_redirects}" >> "$GITHUB_OUTPUT" - name: Find Missing Redirects for Deleted Files @@ -86,18 +82,14 @@ jobs: old="${old#source}" old="${old%.txt}" - # single quotes = ${var} rendered literally; double quotes = $var interpreted redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' # if redirect not already in file, add to string to add to PR description if ! grep -qx "$redirect" $REDIRECTS_FILE; then - deleted_redirects+="$redirect," + deleted_redirects+="
  • [<v>-*]: $redirect
  • " fi done - # cut trailing comma - deleted_redirects="${deleted_redirects%,}" - echo "redirects=${deleted_redirects}" >> "$GITHUB_OUTPUT" - name: Build Redirect HTML @@ -106,20 +98,12 @@ jobs: RENAMED_REDIRECTS: ${{ steps.renamed-files.outputs.redirects }} DELETED_REDIRECTS: ${{ steps.deleted-files.outputs.redirects }} run: | - # empty string that stays empty if there are no redirects to suggest - redirect_html="" - - combined_redirect_string="${RENAMED_REDIRECTS},${DELETED_REDIRECTS}" - - IFS=',' - for redirect in $combined_redirect_string; do - if [[ ! -z "$redirect" ]]; then - if [[ -z "$redirect_html" ]]; then - redirect_html="Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):" - fi - redirect_html+="
  • [<v>-\*]: $redirect
  • " - fi - done + redirect_html='' + combined_redirects="${RENAMED_REDIRECTS}${DELETED_REDIRECTS}" + + if [ -n "$combined_redirects" ]; then + redirect_html="

    Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):

    $combined_redirects" + fi echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" From 4bf1a21057b8c27a807d82a04de31e39666befff Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 15:51:39 -0500 Subject: [PATCH 58/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 4adeeb10..ba5f703f 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -55,7 +55,7 @@ jobs: redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}'"$new"'/' # if redirect not already in file, add to string to add to PR description - if ! grep -qx "$redirect" $REDIRECTS_FILE; then + if ! grep -q "$redirect" $REDIRECTS_FILE; then renamed_redirects+="
  • [<v>-*]: $redirect
  • " fi done @@ -83,9 +83,12 @@ jobs: old="${old%.txt}" redirect='${prefix}/${version}'"$old"'/ -> ${base}/${version}/' - + + # escape special characters before searching for string + escaped_redirect=$(printf '%s\n' "$redirect" | sed 's/[[*${}|\\]/\\&/g') + # if redirect not already in file, add to string to add to PR description - if ! grep -qx "$redirect" $REDIRECTS_FILE; then + if ! grep -qE "${escaped_redirect}$" $REDIRECTS_FILE; then deleted_redirects+="
  • [<v>-*]: $redirect
  • " fi done @@ -102,7 +105,7 @@ jobs: combined_redirects="${RENAMED_REDIRECTS}${DELETED_REDIRECTS}" if [ -n "$combined_redirects" ]; then - redirect_html="

    Suggested redirects for moved/deleted files (replace <v> with earliest backport target version):

    $combined_redirects" + redirect_html="

    Suggested redirects for moved, renamed, and deleted files:

    Replace <v> with the earliest backport target version

    $combined_redirects" fi echo "redirect_html=${redirect_html}" >> "$GITHUB_OUTPUT" From c5f0c59873c34c824e2a9c1081ab8d295c888745 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 16:21:47 -0500 Subject: [PATCH 59/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index ba5f703f..500b1827 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -113,10 +113,10 @@ jobs: - name: Update PR Description uses: MongoCaleb/pr-description-action@4bdfe35b98f64532b419ad20b350a92546cd3aa1 with: - regex: "- \\[ \\] Did you add redirects\\?.*" + regex: "- \\[ \\] If you moved or deleted files.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] Did you add redirects?\n ${{ steps.build-redirect-html.outputs.redirect_html }}" + content: "- [ ] If you moved or deleted files, did you add forward and backward redirects?\n ${{ steps.build-redirect-html.outputs.redirect_html }}" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file From 89296b35bac54fbce254c76d097e877a51458422 Mon Sep 17 00:00:00 2001 From: Mike Woofter <108414937+mongoKart@users.noreply.github.com> Date: Fri, 16 May 2025 16:26:06 -0500 Subject: [PATCH 60/60] Update verify-redirects.yml --- .github/workflows/verify-redirects.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-redirects.yml b/.github/workflows/verify-redirects.yml index 500b1827..0095051e 100644 --- a/.github/workflows/verify-redirects.yml +++ b/.github/workflows/verify-redirects.yml @@ -113,10 +113,10 @@ jobs: - name: Update PR Description uses: MongoCaleb/pr-description-action@4bdfe35b98f64532b419ad20b350a92546cd3aa1 with: - regex: "- \\[ \\] If you moved or deleted files.*" + regex: "- \\[ \\] Did you add forward and backward redirects\\?.*" appendContentOnMatchOnly: false regexFlags: is - content: "- [ ] If you moved or deleted files, did you add forward and backward redirects?\n ${{ steps.build-redirect-html.outputs.redirect_html }}" + content: "- [ ] Did you add forward and backward redirects?\n ${{ steps.build-redirect-html.outputs.redirect_html }}" token: ${{ secrets.GITHUB_TOKEN }} - name: Check for duplicates in redirects file