Raise notice 'insufficient privileges', fix pg_constraint_fn inclusion.

Author: arssher

expected/pathman_permissions.out

@@ -17,7 +17,9 @@ BEGIN
     SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
+NOTICE:  Insufficient priviliges
 /* Grant SELECT to user2 */
 SET ROLE user1;
 GRANT SELECT ON permissions.user1_table TO user2;
@@ -28,7 +30,9 @@ BEGIN
     SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
+NOTICE:  Insufficient priviliges
 /* Should be ok */
 SET ROLE user1;
 SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
@@ -71,7 +75,9 @@ BEGIN
     INSERT INTO permissions.user1_table (id, a) VALUES (35, 0);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
+NOTICE:  Insufficient priviliges
 /* No rights to create partitions (need INSERT privilege) */
 SET ROLE user2;
 SELECT prepend_range_partition('permissions.user1_table');
@@ -133,7 +139,9 @@ BEGIN
     SELECT drop_range_partition('permissions.user1_table_4');
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
+NOTICE:  Insufficient priviliges
 /* Disable automatic partition creation */
 SET ROLE user1;
 SELECT set_auto('permissions.user1_table', false);

sql/pathman_permissions.sql

@@ -23,6 +23,7 @@ BEGIN
     SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
 
 /* Grant SELECT to user2 */
@@ -36,6 +37,7 @@ BEGIN
     SELECT create_range_partitions('permissions.user1_table', 'id', 1, 10, 2);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
 
 /* Should be ok */
@@ -64,6 +66,7 @@ BEGIN
     INSERT INTO permissions.user1_table (id, a) VALUES (35, 0);
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
 
 /* No rights to create partitions (need INSERT privilege) */
@@ -101,6 +104,7 @@ BEGIN
     SELECT drop_range_partition('permissions.user1_table_4');
 EXCEPTION
     WHEN insufficient_privilege THEN
+        RAISE NOTICE 'Insufficient priviliges';
 END$$;
 
 /* Disable automatic partition creation */

src/relation_info.c

@@ -20,9 +20,6 @@
 #include "catalog/catalog.h"
 #include "catalog/indexing.h"
 #include "catalog/pg_constraint.h"
-#if PG_VERSION_NUM < 110000 && PG_VERSION_NUM >= 90600
-#include "catalog/pg_constraint_fn.h"
-#endif
 #include "catalog/pg_inherits.h"
 #include "catalog/pg_type.h"
 #include "miscadmin.h"
@@ -47,8 +44,7 @@
 #if PG_VERSION_NUM < 90600
 #include "optimizer/planmain.h"
 #endif
-
-#if PG_VERSION_NUM >= 90600 && PG_VERSION_NUM < 11000
+#if PG_VERSION_NUM < 110000 && PG_VERSION_NUM >= 90600
 #include "catalog/pg_constraint_fn.h"
 #endif