Skip to content

InitPostgres has changed and compile fails with newest postgres development code #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neiaberau opened this issue Oct 13, 2023 · 1 comment

Comments

@neiaberau
Copy link

not urgent, but as info, it seems InitPostgres has changed and compile fails using newest postgres code on master branch

0.436 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O2 -fPIC -fvisibility=hidden -I. -I./ -I/u01/app/postgres/product/16dev/include/server -I/u01/app/postgres/product/16dev/include/internal -D_GNU_SOURCE -I/usr/include/libxml2 -c -o pg_wait_sampling.o pg_wait_sampling.c
0.610 In file included from pg_wait_sampling.c:37:
0.610 compat.h: In function ‘InitPostgresCompat’:
0.610 compat.h:60:6: error: incompatible type for argument 6 of ‘InitPostgres’
0.610 60 | override_allow_connections, out_dbname);
0.610 | ^~~~~~~~~~~~~~~~~~~~~~~~~~
0.610 | |
0.610 | _Bool
0.610 In file included from pg_wait_sampling.c:17:
0.610 /u01/app/postgres/product/16dev/include/server/miscadmin.h:476:14: note: expected ‘char *’ but argument is of type ‘_Bool’
0.610 476 | char *out_dbname);
0.610 | ~~~~~~^~~~~~~~~~
0.610 In file included from pg_wait_sampling.c:37:
0.610 compat.h:59:2: error: too many arguments to function ‘InitPostgres’
0.610 59 | InitPostgres(in_dbname, dboid, username, useroid, load_session_libraries,
0.610 | ^~~~~~~~~~~~
0.610 In file included from pg_wait_sampling.c:17:
0.610 /u01/app/postgres/product/16dev/include/server/miscadmin.h:473:13: note: declared here
0.610 473 | extern void InitPostgres(const char *in_dbname, Oid dboid,
0.610 | ^~~~~~~~~~~~
0.630 make: *** [: pg_wait_sampling.o] Error 1

@shinderuk
Copy link
Contributor

Fixed in #70. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants