Add --snapfs-snapshot option to pg_dumpall

Author: knizhnik

src/bin/pg_dump/pg_dump.c

@@ -1188,9 +1188,11 @@ setup_connection(Archive *AH, const char *dumpencoding,
 
 	if (AH->snapfs_snapshot_id)
 	{
-		char sql[64];
-		sprintf(sql, "select pg_set_backend_snapshot(%s)", AH->snapfs_snapshot_id);
-		PQclear(ExecuteSqlQueryForSingleRow((Archive *) AH, sql));
+		PQExpBuffer query = createPQExpBuffer();
+
+		appendPQExpBuffer(query, "select pg_set_backend_snapshot(%s)",  AH->snapfs_snapshot_id);
+		PQclear(ExecuteSqlQueryForSingleRow((Archive *) AH, query->data));
+		destroyPQExpBuffer(query);
 	}
 }
 

src/bin/pg_dump/pg_dumpall.c

@@ -139,6 +139,7 @@ main(int argc, char *argv[])
 		{"no-sync", no_argument, NULL, 4},
 		{"no-unlogged-table-data", no_argument, &no_unlogged_table_data, 1},
 		{"on-conflict-do-nothing", no_argument, &on_conflict_do_nothing, 1},
+		{"snapfs-snapshot", required_argument, NULL, 5},
 
 		{NULL, 0, NULL, 0}
 	};
@@ -318,6 +319,11 @@ main(int argc, char *argv[])
 				appendPQExpBufferStr(pgdumpopts, " --no-sync");
 				break;
 
+		    case 5:
+				appendPQExpBufferStr(pgdumpopts, " --snapfs-snapshot ");
+				appendShellString(pgdumpopts, optarg);
+				break;
+
 			default:
 				fprintf(stderr, _("Try \"%s --help\" for more information.\n"), progname);
 				exit_nicely(1);
@@ -627,6 +633,7 @@ help(void)
 	printf(_("  --no-unlogged-table-data     do not dump unlogged table data\n"));
 	printf(_("  --on-conflict-do-nothing     add ON CONFLICT DO NOTHING to INSERT commands\n"));
 	printf(_("  --quote-all-identifiers      quote all identifiers, even if not key words\n"));
+	printf(_("  --snapfs-snapshot=SNAPSHOT   use given SNAPFS snapshot for the dump\n"));
 	printf(_("  --use-set-session-authorization\n"
 			 "                               use SET SESSION AUTHORIZATION commands instead of\n"
 			 "                               ALTER OWNER commands to set ownership\n"));