-
-
Notifications
You must be signed in to change notification settings - Fork 66
Only show the copy button when hovering #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
You should probably add it to the project, I doubt many will check this issue tracker. |
Please keep it possible to copy from a touchscreen. |
That would be good, but to indicate there is text behind it making it somewhat transparent too would be nice IMO. |
The example given on discord (https://pradyunsg.me/furo/kitchen-sink/blocks/#literal-blocks) allows that by first tapping on the codeblock (probably some :active/:focus CSS rule) which I think is also fine, but a padding would work too |
I'm taking a look |
I fixed the issue in this PR. I decided to go with the hover approach, I think it looks better than the |
(Reported by @StanFromIreland on Discord)
The new copy button can sometimes cover part of the source code:
https://docs.python.org/dev/library/string.html#format-examples
We can fix this by making the copy button appear only when hovered.
Please don't pick up this issue, I'd like to reserve it for someone at the PyConUS sprints :)
The text was updated successfully, but these errors were encountered: