You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On this and the prettier-ruby gem, I found that the "everything in one file" situation to be a bit of an obstacle to contributing and understanding what's going on. I notice you've started splitting up the different pieces - would you be open to a PR that puts each Node subclass in its own file?
The text was updated successfully, but these errors were encountered:
I don't really want to move them into different files tbh. I do want to move the entire formatting capability out into its own thing, and just keep the node definitions together. The thing is when they're in the same file it makes it really easy to make mass changes, as I have so far with the visitor pattern, pretty printing, and inheriting from the parent node class. It would have been harder doing that in different files.
On this and the prettier-ruby gem, I found that the "everything in one file" situation to be a bit of an obstacle to contributing and understanding what's going on. I notice you've started splitting up the different pieces - would you be open to a PR that puts each Node subclass in its own file?
The text was updated successfully, but these errors were encountered: